[r2r] gui-auth & enable_v2 rpc implementation #1335

onur-ozkan · 2022-07-08T09:01:24Z

gui-auth implementation
enable_eth_with_tokens and enable_erc20 rpc implementations

example: enable_eth_with_tokens payload:

curl -v --url "http://127.0.0.1:7783" -s --data '{
	"userpass": "'$userpass'",
	"mmrpc": "2.0",
	"method": "enable_eth_with_tokens",
	"params": {
		"ticker": "ETH",
		"nodes": [
			{"url": "https://auth.defimania.live/ethereum", "gui_auth": true }
		],
		"swap_contract_address": "0x24ABE4c71FC658C91313b6552cd40cD808b3Ea80",
		"erc20_tokens_requests": [
			{
				"ticker": "USDC-ERC20"
			},
			{
				"ticker": "SHIB-ERC20"
			}
		]
	},
	"id": 0
}'

example: enable_erc20 payload:

curl -v --url "http://127.0.0.1:7783" -s --data '{
	"userpass": "'$userpass'",
	"mmrpc": "2.0",
	"method": "enable_erc20",
	"params": {
		"ticker": "USDT-ERC20",
		"activation_params": {}
	},
	"id": 0
}'

future tasks:

writing tests for enable_eth_with_tokens and enable_erc20

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…i-auth-implementation Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…pping Signed-off-by: Onur Özkan <work@onurozkan.dev>

…Impl` Signed-off-by: ozkanonur <work@onurozkan.dev>

artemii235

🔥

artemii235 · 2022-08-02T06:50:56Z

@sergeyboyko0791 @shamardy Please take a look too 🙂

sergeyboyko0791

Great enhancement!
First review iteration.

mm2src/coins/eth.rs

mm2src/coins/eth/eth_tests.rs

mm2src/coins/eth/web3_transport.rs

Signed-off-by: ozkanonur <work@onurozkan.dev>

shamardy

Great Work! Only 2 comments :)

mm2src/coins_activation/src/eth_with_token_activation.rs

mm2src/coins/eth/web3_transport.rs

sergeyboyko0791

Finished the previous review iteration

mm2src/coins/eth/v2_activation.rs

mm2src/coins/eth/web3_transport.rs

mm2src/coins/lp_coins.rs

mm2src/coins_activation/src/eth_with_token_activation.rs

mm2src/common/common.rs

Signed-off-by: ozkanonur <work@onurozkan.dev>

shamardy

Thanks for the fixes! Only one more comment :)

mm2src/coins_activation/src/eth_with_token_activation.rs

Signed-off-by: ozkanonur <work@onurozkan.dev>

sergeyboyko0791

Thank you for the fixes!
LGTM

This reverts commit 5975d6a.

Signed-off-by: Onur Özkan <work@onurozkan.dev>

shamardy · 2022-08-04T11:13:40Z

mm2src/coins/eth/v2_activation.rs

@@ -29,7 +29,6 @@ pub struct EthActivationV2Request {
    pub gas_station_policy: GasStationPricePolicy,
    pub mm2: Option<u8>,
    #[serde(default)]


I guess this #[serde(default)] is not needed anymore.

Yeah I missed it, thanks!

Signed-off-by: Onur Özkan <work@onurozkan.dev>

shamardy

LGTM!

onur-ozkan and others added 26 commits July 5, 2022 19:36

implement validation strcuture

b0cefff

Signed-off-by: Onur Özkan <work@onurozkan.dev>

add signed_message to payload if exists

cbb30d6

Signed-off-by: ozkanonur <work@onurozkan.dev>

update doc-comment of drop_mutability macro

f5912ae

Signed-off-by: ozkanonur <work@onurozkan.dev>

update fn sign_message_hash

e366fff

Signed-off-by: Onur Özkan <work@onurozkan.dev>

fill gui_auth_message_prefix fields for tests

85a6404

Signed-off-by: ozkanonur <work@onurozkan.dev>

create and implement trait GuiAuthMessages

9efd6bc

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

a59f4bd

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

6a79d3c

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

84ec84f

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

903edf3

Signed-off-by: ozkanonur <work@onurozkan.dev>

save development state

19ffa09

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

f83f5b3

Signed-off-by: ozkanonur <work@onurozkan.dev>

save development state

6f36e60

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

469e093

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

e7bada5

Signed-off-by: Onur Özkan <work@onurozkan.dev>

save development state

944a354

Signed-off-by: ozkanonur <work@onurozkan.dev>

finalize fn enable_v2 implementation

3bdc56b

Signed-off-by: ozkanonur <work@onurozkan.dev>

force UTC tz for gui-auth signed messages

697e7d5

Signed-off-by: ozkanonur <work@onurozkan.dev>

optimize Web3Transport initialization

e02b13c

Signed-off-by: ozkanonur <work@onurozkan.dev>

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into gu…

5fee6a8

…i-auth-implementation Signed-off-by: ozkanonur <work@onurozkan.dev>

save development state

2a5e084

Signed-off-by: ozkanonur <work@onurozkan.dev>

inline Web3Transport initialization functions

423ca6e

Signed-off-by: ozkanonur <work@onurozkan.dev>

Update Cargo.toml

0466601

update version handling of eth coins

4c6453f

Signed-off-by: Onur Özkan <work@onurozkan.dev>

provide better error handling

74ce301

Signed-off-by: ozkanonur <work@onurozkan.dev>

simplify generate_gui_auth_signed_validation

a75014a

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan requested review from artemii235, caglaryucekaya, laruh and sergeyboyko0791 July 13, 2022 11:03

update InvalidSwapContractAddr and InvalidFallbackSwapContract ma…

7bf4e57

…pping Signed-off-by: Onur Özkan <work@onurozkan.dev>

artemii235 mentioned this pull request Jul 29, 2022

Enable/electrum/my_balance 2.0 specification/ideas. #1006

Open

7 tasks

refactor AsyncMutex to std one for eth20_tokens_infos of `EthCoin…

af3ed50

…Impl` Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan changed the title ~~[wip] gui-auth & enable_v2 rpc implementation~~ [r2r] gui-auth & enable_v2 rpc implementation Jul 30, 2022

artemii235 previously approved these changes Aug 2, 2022

View reviewed changes

sergeyboyko0791 suggested changes Aug 2, 2022

View reviewed changes

fix pr notes

31605e5

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan dismissed artemii235’s stale review via 31605e5 August 2, 2022 11:35

onur-ozkan requested a review from sergeyboyko0791 August 2, 2022 12:36

shamardy reviewed Aug 2, 2022

View reviewed changes

mm2src/coins_activation/src/eth_with_token_activation.rs Outdated Show resolved Hide resolved

mm2src/coins/eth/web3_transport.rs Outdated Show resolved Hide resolved

mm2src/coins/eth/web3_transport.rs Outdated Show resolved Hide resolved

sergeyboyko0791 reviewed Aug 3, 2022

View reviewed changes

onur-ozkan added 2 commits August 3, 2022 15:05

fix pr reviews

8c37c20

Signed-off-by: ozkanonur <work@onurozkan.dev>

fix pr reviews

528bdb3

Signed-off-by: ozkanonur <work@onurozkan.dev>

shamardy reviewed Aug 3, 2022

View reviewed changes

mm2src/coins_activation/src/eth_with_token_activation.rs Outdated Show resolved Hide resolved

onur-ozkan added 2 commits August 3, 2022 21:00

create Web3Transport::single_node fn

bc60c20

Signed-off-by: ozkanonur <work@onurozkan.dev>

update start_history_background_fetching return type

5975d6a

Signed-off-by: ozkanonur <work@onurozkan.dev>

sergeyboyko0791 previously approved these changes Aug 4, 2022

View reviewed changes

Revert "update start_history_background_fetching return type"

a691c94

This reverts commit 5975d6a.

onur-ozkan dismissed sergeyboyko0791’s stale review via a691c94 August 4, 2022 10:21

remove tx_history for eth v2 activation

a67c162

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan requested review from artemii235, shamardy and sergeyboyko0791 August 4, 2022 10:59

shamardy reviewed Aug 4, 2022

View reviewed changes

fix

9c011f2

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan requested a review from shamardy August 4, 2022 12:15

shamardy approved these changes Aug 4, 2022

View reviewed changes

artemii235 merged commit 6631a20 into dev Aug 5, 2022

artemii235 deleted the gui-auth-implementation branch August 5, 2022 05:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[r2r] gui-auth & enable_v2 rpc implementation #1335

[r2r] gui-auth & enable_v2 rpc implementation #1335

onur-ozkan commented Jul 8, 2022 •

edited

Loading

artemii235 left a comment

artemii235 commented Aug 2, 2022

sergeyboyko0791 left a comment

shamardy left a comment

sergeyboyko0791 left a comment

shamardy left a comment

sergeyboyko0791 left a comment

shamardy Aug 4, 2022 •

edited

Loading

onur-ozkan Aug 4, 2022

shamardy left a comment

[r2r] gui-auth & enable_v2 rpc implementation #1335

[r2r] gui-auth & enable_v2 rpc implementation #1335

Conversation

onur-ozkan commented Jul 8, 2022 • edited Loading

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 commented Aug 2, 2022

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

shamardy Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

onur-ozkan Aug 4, 2022

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

onur-ozkan commented Jul 8, 2022 •

edited

Loading

shamardy Aug 4, 2022 •

edited

Loading