[r2r] get_current_mtp rpc impl #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
|
@shamardy this PR is ready for review |
borngraced
changed the title
shamardy
requested changes
Jul 13, 2022
| fn status_code(&self) -> StatusCode { | ||
| match self { | ||
| GetCurrentMtpError::Internal(_) => StatusCode::INTERNAL_SERVER_ERROR, | ||
| GetCurrentMtpError::NotSupported(_) => StatusCode::INTERNAL_SERVER_ERROR, |
Comment on lines
50
to
52
| let coin = lp_coinfind_or_err(&ctx, &req.coin).await?; | ||
|
|
||
| match coin { |
borngraced
changed the title
borngraced
changed the title
shamardy
requested changes
Jul 14, 2022
|
@shamardy this is ready for review. thanks |
|
Makes sense in this case 💯
…On Fri, 15 Jul 2022 at 19:42, shamardy ***@***.***> wrote:
***@***.**** commented on this pull request.
Only one more minor fix 🙂
------------------------------
In mm2src/coins/rpc_command/get_current_mtp.rs
<#1340 (comment)>
:
> + GetCurrentMtpError::NoSuchCoin(_) => StatusCode::NOT_FOUND,
+ GetCurrentMtpError::RpcError(_) | GetCurrentMtpError::NotSupportedCoin(_) => StatusCode::BAD_REQUEST,
NoSuchCoin should be StatusCode::PRECONDITION_REQUIRED since the coin
activation is a precondition to using it in this case.
I guess the best fit for RpcError is StatusCode::INTERNAL_SERVER_ERROR
although it's not implemented like this everywhere else.
—
Reply to this email directly, view it on GitHub
<#1340 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AML2KX3LST23Y5R3HGYSLADVUGWIJANCNFSM53ORYKPQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
@sergeyboyko0791 can you please have a look at this PR too? |
sergeyboyko0791
approved these changes
Jul 25, 2022
| ]); | ||
| let passphrase = "cMhHM3PMpMrChygR4bLF7QsTdenhWpFrrmf2UezBG3eeFsz41rtL"; | ||
|
|
||
| let conf = Mm2TestConf::seednode(&passphrase, &coins); |
There was a problem hiding this comment.
I think it's overhead to run a seednode in this test.
Seednode opens a server socket and listens for incoming P2P connections.
But anyway it's not critical now
…into get_current_mtp_rpc
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_current_mtpAPI call #1338