[r2r] NMC BlockHeader deserializing bug fix #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
sergeyboyko0791
suggested changes
Jul 29, 2022
borngraced
changed the title
borngraced
changed the title
shamardy
reviewed
Jul 29, 2022
| // NMC block headers | ||
| // start - #622807 | ||
| // end - #622796 | ||
| // Ref: https://chainz.cryptoid.info/nmc/block.dws?622807.htm |
There was a problem hiding this comment.
This is a very nice block explorer that shows the raw header with it's fields and the same for transactions for a lot of coins, this should be handy in a lot of similar serialization/deserialization issues :)
There was a problem hiding this comment.
Right, it helped a lot while debugging 💯💯
shamardy
previously approved these changes
Jul 29, 2022
|
@borngraced please fix the |
borngraced
dismissed stale reviews from sergeyboyko0791 and shamardy
via
ae7466d
Fixed. |
|
@sergeyboyko0791 @shamardy any updates on this? It's pending for 12 days, which is not acceptable. |
|
PS my review is not required. |
…into NMC-non-final
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
NMCnon-final error on swap refund and BlockHeader deserializing bug + unit testFixes #1281