[r2r] refactor p2p message processing flow #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
…rkflow-optimization-on-broadcasts
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: Onur Özkan <work@onurozkan.dev>
Signed-off-by: Onur Özkan <work@onurozkan.dev>
Signed-off-by: Onur Özkan <work@onurozkan.dev>
Signed-off-by: Onur Özkan <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
changed the title
Signed-off-by: ozkanonur <work@onurozkan.dev>
…ion` Signed-off-by: ozkanonur <work@onurozkan.dev>
artemii235
requested changes
Aug 10, 2022
Signed-off-by: Onur Özkan <work@onurozkan.dev>
onur-ozkan
changed the title
artemii235
previously approved these changes
Aug 10, 2022
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
changed the title
…rkflow-optimization-on-broadcasts
Signed-off-by: ozkanonur <work@onurozkan.dev>
shamardy
reviewed
Aug 11, 2022
Signed-off-by: Onur Özkan <work@onurozkan.dev>
shamardy
previously approved these changes
Aug 12, 2022
sergeyboyko0791
suggested changes
Aug 12, 2022
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
borngraced
pushed a commit
that referenced
this pull request
Aug 17, 2022
* refactor p2p message processing flow Signed-off-by: ozkanonur <work@onurozkan.dev> * drop `message` mutability in `process_p2p_message` Signed-off-by: ozkanonur <work@onurozkan.dev> * refactor `fn tx_enum_from_bytes` error type Signed-off-by: Onur Özkan <work@onurozkan.dev> * check topics in `lp_topic_list_validation` Signed-off-by: Onur Özkan <work@onurozkan.dev> * optimize Signed-off-by: Onur Özkan <work@onurozkan.dev> * check if there is any byte left in tx deserialization Signed-off-by: Onur Özkan <work@onurozkan.dev> * add backwards comparison in `fn deserialization` Signed-off-by: Onur Özkan <work@onurozkan.dev> * rollback 78c6810 Signed-off-by: Onur Özkan <work@onurozkan.dev> * set JEMALLOC_SYS_WITH_MALLOC_CONF on build pipelines Signed-off-by: ozkanonur <work@onurozkan.dev> * Update README.md * add `_` to unused variables Signed-off-by: ozkanonur <work@onurozkan.dev> * refactor `lp_topic_list_validation` as `topic_prefix_and_coin_validation` Signed-off-by: ozkanonur <work@onurozkan.dev> * fix reviews Signed-off-by: Onur Özkan <work@onurozkan.dev> * update `tx_enum_from_bytes` and write unit test Signed-off-by: ozkanonur <work@onurozkan.dev> * update `tx_enum_from_bytes` in tendermint Signed-off-by: ozkanonur <work@onurozkan.dev> * update error log of `process_p2p_message` Signed-off-by: Onur Özkan <work@onurozkan.dev> * create `TxMarshalingErr` Signed-off-by: ozkanonur <work@onurozkan.dev> * fix `test_tx_enum_from_bytes` Signed-off-by: ozkanonur <work@onurozkan.dev> * fix test compilation Signed-off-by: ozkanonur <work@onurozkan.dev> Signed-off-by: ozkanonur <work@onurozkan.dev> Signed-off-by: Onur Özkan <work@onurozkan.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions:
x86_64send_raw_tx_bytess future to avoid blocking the iteratortxhlptopic prefix, check if tx is valid, if notcontinue.