[r2r] Implement TX history V2 for UTXO coins activated with a Hardware wallet #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `UtxoTxHistoryOps`, implement it for `BchCoin` * Remove `UtxoStandardOps` implementation for `BchCoin` * TODO implement `WaitForHistoryUpdateTrigger` state
…ardCoin` * Add `taget: MyTxHistoryTarget` field to `my_tx_history` request * Add `utxo_common/utxo_tx_history_common.rs` for TX history related common impl * Add `HDWalletCoinOps::derive_known_addresses` * Refactor `GetTxHistoryFilters` by requiring to set `from_addresses` * Fix `tx_history_v2_tests`
* Implement `UtxoTxHistoryOps` and `CoinWithTxHistoryV2` for `QtumCoin`
* Implement `WaitForHistoryUpdateTrigger` state * Add `ElectrumClient::scripthash_get_history_batch` * Implement `UtxoTxHistoryOps::request_tx_history` according to `DerivationMethod` * Add `CoinBalanceReportOps` trait * Don't spawn legacy tx_history loop on `init_utxo`, `init_qtum` RPCs * Rename `EnableCoinBalance` to `CoinBalanceReport`
* Rename `utxo_tx_history_common.rs` to `utxo_tx_history_v2_common.rs`
…tory V2 * Add `UtxoTxHistoryOps::tx_from_storage_or_rpc` * Fix `CoinWithTxHistoryV2::get_tx_history_filters`, `UtxoTxHistoryOps::request_tx_history`
…ps::tx_details_by_hash`
* Add `UtxoMyAddressesHistoryError` for `UtxoTxHistoryOps::my_addresses` * Optimize `UtxoTxHistoryOps::request_tx_history` by passing `my_addresses` argument
* Use `utxo_common::request_tx_history` for `BchCoin` instead of `utxo_tx_history_v2_common`'s
sergeyboyko0791
changed the title
artemii235
requested changes
Sep 12, 2022
There was a problem hiding this comment.
Thanks for the great work! Could you please also add an integration test for history in HD mode similar to https://github.com/KomodoPlatform/atomicDEX-API/blob/e420d60fa1d5df3963418cf25d728ef04c5bbccd/mm2src/mm2_main/src/mm2_tests/bch_and_slp_tests.rs#L390?
mm2src/coins/utxo/bch.rs
Outdated
| .compat(), | ||
| ) | ||
| fn process_history_loop(&self, _ctx: MmArc) -> Box<dyn Future<Item = (), Error = ()> + Send> { | ||
| warn!("'process_history_loop' is not deprecated for BchCoin! Consider using 'my_tx_history_v2'"); |
There was a problem hiding this comment.
It seems you meant is not implemented or is deprecated.
| async fn get_block_timestamp(&self, height: u64) -> MmResult<u64, UtxoRpcError>; | ||
|
|
||
| /// Requests balances of all activated coin's addresses. | ||
| async fn get_addresses_balances(&self) -> BalanceResult<HashMap<String, BigDecimal>>; |
There was a problem hiding this comment.
my_addresses_balances seems a more suitable name. I personally would expect this method to accept addresses as argument with current name.
| } | ||
|
|
||
| if to_update { | ||
| return Self::change_state(FetchingTxHashes::new()); |
There was a problem hiding this comment.
In FetchingTxHashes state, it will fetch history for all addresses - can be quite an overhead. We need only addresses whose balance was changed here.
There was a problem hiding this comment.
This led to a huge refactoring of some of the TX history storage methods and the TX history states.
I tried to cover most of the cases in tx_history_v2_tests.rs module.
shamardy
previously approved these changes
Sep 13, 2022
sergeyboyko0791
changed the title
* Optimize TX history states by specifying `FetchingTxHashes::fetch_for_addresses` * Rename `UtxoTxHistoryOps::get_addresses_balances` to `my_addresses_balances` * Add `UtxoTxHistoryOps::address_from_str` to parse addresses within `UtxoTxHistoryOps::my_addresses_balances` result * Add `AddrFromStrError`
… function * Add `SqlQuery::count_distinct`
…s` and `get_unconfirmed_txes_from_history` functions
* Fix `SqlTxHistoryStorage` to repeat the same ordering as in `compare_transaction_details` * Fix tests * Use `utxo_common::utxo_tx_history_v2_common::request_tx_history` within for BCH coin * Move `utxo_coin_fields_for_test` to `utxo_common_tests.rs`
* Add `T_BCH_ELECTRUMS` listening on WSS port
sergeyboyko0791
changed the title
|
@artemii235 @shamardy this PR is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.