[r2r] Retry tx wait confirmation if not on chain #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
artemii235
previously approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Thanks for the fast fix! Looks good to me. Though, @sergeyboyko0791 and @shamardy may have some notes 🙂
shamardy
requested changes
Sep 19, 2022
shamardy
previously approved these changes
Sep 19, 2022
borngraced
added a commit
that referenced
this pull request
Sep 30, 2022
* enable retry if tx is not available onchain * fixed review notes * fixed failing tests * pr review fixes * set test timeout to 1
sergeyboyko0791
pushed a commit
that referenced
this pull request
Oct 11, 2022
* pubkey and secret validation done * Validate taker and maker coin contract * impl scret_hash validation * optimized swap_contract_addre validation * unimplement negotiate_coin_contract_address for slp.rs * removed coin contract addr validation — Postponed * added unit test for parameters * remove unused * PR review fixes * removed validate_secret_hash method from trait * removed validate_secret_hash method from trait * [r2r] Retry tx wait confirmation if not on chain (#1474) * enable retry if tx is not available onchain * fixed review notes * fixed failing tests * pr review fixes * set test timeout to 1 * minor fixes * fix tests * fixed secret_hash check * cargo fmt * pr riview fix * use real pubkey for test case * use correct raw tx bytes for extract_secret test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
wait_for_confirmationsto retry a tx request if we gettx is not on chain anymoreerror.fixes: #1473