[r2r] fixed block_header_utxo_loop #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
sergeyboyko0791
suggested changes
Oct 25, 2022
Comment on lines
298
to
301
| pub struct BlockHeaderInMemoryStorage { | ||
| pub ticker: String, | ||
| pub conn: Arc<Mutex<Connection>>, | ||
| } |
There was a problem hiding this comment.
This can be simplified significantly since BlockHeaderInMemoryStorage is used in tests only:
pub struct BlockHeaderInMemoryStorage {
pub ticker: String,
// The block headers should be ordered to be able to return the last block header.
pub block_headers: BTreeMap<u64, BlockHeader>,
// This can be used on [`BlockHeaderStorageOps::get_block_height_by_hash`].
pub block_headers_by_hash: HashMap<H256, BlockHeader>,
}Please also note that get_last_block_height should be configurable from a test. For example, at the beginning of a test you can just upload one block header with a specified height. Also there could be a field like BlockHeaderInMemoryStorage::last_block_height.
There was a problem hiding this comment.
noted for next PR. THANKS
shamardy
requested changes
Oct 26, 2022
shamardy
reviewed
Oct 26, 2022
borngraced
changed the title
sergeyboyko0791
previously approved these changes
Oct 27, 2022
shamardy
previously approved these changes
Oct 27, 2022
borngraced
dismissed stale reviews from shamardy and sergeyboyko0791
via
4212b20
|
@cipig could you please test this fix? There shouldn't be |
Looks good, the error message is gone |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this comment: #1482 (comment)