[r2r] Use futures_timer crate and fix unstable tests
#1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `TimedMutexGuard` as it's not used anymore
sergeyboyko0791
changed the title
futures_timer cratefutures_timer crate and fix unstable tests
sergeyboyko0791
requested review from
artemii235,
laruh,
borngraced and
onur-ozkan
and removed request for
laruh
|
Initially, I thought that the Also I figured out that |
artemii235
previously approved these changes
Oct 27, 2022
borngraced
reviewed
Oct 27, 2022
Comment on lines
27
to
29
| pub fn sleep_ms(ms: u32) -> Timer { | ||
| let seconds = gstuff::duration_to_float(Duration::from_millis(ms as u64)); | ||
| Timer { | ||
| till_utc: now_float() + seconds, | ||
| delay: Delay::new(Duration::from_millis(ms as u64)), |
There was a problem hiding this comment.
Why is sleep_ms param not u64 by default instead of requesting for u32 and then casting to u64?
There was a problem hiding this comment.
That's a good question! I don't know actually, but I think it's worth to change to u64
borngraced
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimedMutexGuardas it's not used anymore