remove unnecessary unsafe block

[onur-ozkan]

Signed-off-by: ozkanonur work@onurozkan.dev

[artemii235]

@ozkanonur It was already done in this PR: #1514

[onur-ozkan]

@ozkanonur It was already done in this PR: #1514

Seems I couldn't pull it, sorry. Let me rebase the branch and only keep the unsafe commit. It's not required to be used there.

ps: That PR casts u64 to u32, that might cause problems which we talk in here

[sergeyboyko0791]

There shouldn't be problem because even if sleep_ms: u64 == u64::MAX, then it will be casted to sleep_ms as u32 == u32::MAX.

ps: That PR casts u64 to u32, that might cause problems which we talk in #1500

[onur-ozkan]

There shouldn't be problem because even if sleep_ms: u64 == u64::MAX, then it will be casted to sleep_ms as u32 == u32::MAX.

ps: That PR casts u64 to u32, that might cause problems which we talk in #1500

I guess we have a condition that checks if bigger than i32::MAX then in that function? Because thats very unpredictable scenario. It will not be always equal to max i32. It can be random number between 0-max u32 if there is no conditional checks.

[sergeyboyko0791]

Yes, that would be true if we casted u64 to i32, but we cast u64 to u32. Do I miss something?

I guess we have a condition that checks if bigger than i32::MAX then in that function? Because thats very unpredictable scenario. It will not be always equal to max i32. It can be random number between 0-max u32 if there is no conditional checks.

[onur-ozkan]

Yes, that would be true if we casted u64 to i32, but we cast u64 to u32. Do I miss something?

I guess we have a condition that checks if bigger than i32::MAX then in that function? Because thats very unpredictable scenario. It will not be always equal to max i32. It can be random number between 0-max u32 if there is no conditional checks.

It's same for all castings from a type that supports bigger value to type support smaller value.

eg:

fn main() {
    // MAX value of unsigned 32 byte + 10
    let x: u64 = 4294967295 + 10;
    assert_eq!(x as u32, std::u32::MAX, "{} is not {}", x as u32, std::u32::MAX);
}

[sergeyboyko0791]

I was wrong... I thought I tested exactly the same case that you mentioned above, but it looks like I didn't...
Thank you for the clarification! Could you please fix it in this PR?
@ozkanonur

[onur-ozkan]

I was wrong... I thought I tested exactly the same case that you mentioned above, but it looks like I didn't... Thank you for the clarification! Could you please fix it in this PR? @ozkanonur

I will implement the safe-casting macros and update non-safe castings with using that macro. I will do it at weekend and make it r2r before monday morning. Today I have some debugging work on tendermint

[artemii235]

👍