Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Block header UTXO Loop Test Impl #1519

Merged
merged 22 commits into from
Dec 19, 2022
Merged

[r2r] Block header UTXO Loop Test Impl #1519

merged 22 commits into from
Dec 19, 2022

Conversation

borngraced
Copy link
Member

No description provided.

sergeyboyko0791 and others added 2 commits October 28, 2022 13:57
@sergeyboyko0791
Prepare Block Header Storage for test
086216e
@borngraced
first working test impl
2c9e2ae 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced borngraced self-assigned this Oct 31, 2022
borngraced and others added 5 commits October 31, 2022 15:12
@borngraced
remove println
2541b2e 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced
cargo fmt
0b436bb 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced
fix test
09461c9 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced
Merge remote-tracking branch 'origin/dev' into block-header-test
14f34b8
@borngraced
fix wasm
01b2aa0 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced borngraced changed the title Block header UTXO Loop Test Impl [r2r] Block header UTXO Loop Test Impl Oct 31, 2022
@borngraced
minor fixes/improvements
78b5ef4 
Signed-off-by: borngraced <samuelonoja970@gmail.com>
sergeyboyko0791
sergeyboyko0791 suggested changes Nov 3, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this attempt! I've left a few notes, hope they will point to the right direction 🙂

mm2src/coins/utxo/utxo_block_header_storage/mod.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
@borngraced borngraced changed the title [r2r] Block header UTXO Loop Test Impl [wip] Block header UTXO Loop Test Impl Nov 5, 2022
@borngraced borngraced changed the title [wip] Block header UTXO Loop Test Impl [r2r] Block header UTXO Loop Test Impl Dec 6, 2022
@borngraced borngraced changed the title [r2r] Block header UTXO Loop Test Impl [wip] Block header UTXO Loop Test Impl Dec 6, 2022
@borngraced borngraced changed the title [wip] Block header UTXO Loop Test Impl [r2r] Block header UTXO Loop Test Impl Dec 7, 2022
sergeyboyko0791
sergeyboyko0791 suggested changes Dec 8, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks better, but there are still things to improve)

mm2src/coins/utxo/utxo_block_header_storage/mod.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_builder/utxo_arc_builder.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_builder/utxo_arc_builder.rs Show resolved Hide resolved
mm2src/coins/utxo/utxo_builder/utxo_arc_builder.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_builder/utxo_arc_builder.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
@borngraced
fix review notes & improved test
72b1554 
Signed-off-by: borngraced <samiodev@icloud.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced
Merge remote-tracking branch 'origin/dev' into block-header-test
13ac625
@borngraced
fix clippy
636751e 
Signed-off-by: borngraced <samiodev@icloud.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
@borngraced
fix wasm build
feda70a 
Signed-off-by: borngraced <samiodev@icloud.com>
sergeyboyko0791
sergeyboyko0791 suggested changes Dec 14, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the last review from me :)

mm2src/coins/utxo/rpc_clients.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/rpc_clients.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
@borngraced
fix review notes
d41d569 
Signed-off-by: borngraced <samiodev@icloud.com>
sergeyboyko0791
sergeyboyko0791 previously approved these changes Dec 16, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

@sergeyboyko0791
Copy link

@shamardy could you please take a look?

shamardy
shamardy previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one unneeded line in the test.

mm2src/coins/utxo/utxo_tests.rs Outdated Show resolved Hide resolved
@borngraced
removed unneeded variable decl
58c6c16 
Signed-off-by: borngraced <samiodev@icloud.com>
shamardy
shamardy approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@sergeyboyko0791 sergeyboyko0791 merged commit 6c90c28 into dev Dec 19, 2022
@sergeyboyko0791 sergeyboyko0791 deleted the block-header-test branch December 19, 2022 10:18
@borngraced borngraced mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 left review comments

Assignees

@borngraced borngraced

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borngraced @sergeyboyko0791 @shamardy