[r2r] Group SwapOps method arguments #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments # Conflicts: # mm2src/coins/qrc20.rs # mm2src/coins/solana.rs # mm2src/coins/solana/spl.rs # mm2src/coins/tendermint/tendermint_coin.rs # mm2src/coins/tendermint/tendermint_token.rs # mm2src/coins/test_coin.rs # mm2src/coins/utxo/bch.rs # mm2src/coins/utxo/qtum.rs # mm2src/coins/utxo/slp.rs # mm2src/coins/utxo/utxo_standard.rs # mm2src/coins/z_coin.rs
…rguments # Conflicts: # mm2src/coins/tendermint/tendermint_coin.rs
sergeyboyko0791
suggested changes
Nov 3, 2022
laruh
changed the title
…rguments # Conflicts: # mm2src/mm2_main/src/docker_tests.rs
laruh
changed the title
sergeyboyko0791
approved these changes
Nov 8, 2022
|
@artemii235 please take a quick look, then I'll merge the PR |
laruh
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: Group SwapOps method arguments into new types #1504
There are new three groups for
send paymentmethods and two structures forvalidate_feeandcheck_if_my_payment_sent.validate_feemethod didn't have annotation to allow too many arguments, but already had 6 arguments except &self.