[r2r] Repeatable future #1564
[r2r] Repeatable future #1564
Conversation
* Use the `repeatable` future as an example at `utxo_coin_builder.rs`
* Refactor `custom_futures` * Remove `SendAll` future
* Add `Repeatable::inspect_err` * Add the possibility to convert `Result<T, E>` into `Action<T, E>`
* Add `retry_on_err` macro that expects from the future to return a result
* Fill doc comments
|
@shamardy @borngraced @laruh @caglaryucekaya, PR is ready for the review :) |
| while now_ms() / 1000 < wait_until { | ||
| Timer::sleep(3.).await; | ||
| // Let the storage to be initialized for the given coin. | ||
| Timer::sleep(1.).await; |
There was a problem hiding this comment.
you changed the time?? why tho?
There was a problem hiding this comment.
I've left the sleep timeout between attempts the same - 3 seconds as before:
.repeat_every(Duration::from_secs(3))But as you can see (before my changes), the sleep timer was at the beginning of this function (i.e. before the first attempt). It's required to let the storage to initialize everything it needs before the first my_tx_history_v2_impl attempt.
repeatable doesn't allow to sleep before the first attempt, so I decided to put a sleep at the beginning of this function.
It's enough to sleep for 1 second to let the storage to initialize all required SQL tables.
sergeyboyko0791
dismissed stale reviews from laruh and borngraced
via
d7066ec
* Allow the user to specify only `until_ms` * Avoid declaring `exec_fut: F` and `repeat_every: Duration` optional
* Add `RepeatUntil` enum * Set the default `repeat_every` to 1s * Panic on `total_attempts == 0`
|
@artemii235 the PR is ready for the next review |
No description provided.