Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] validate input_tx is calling 'receiverSpend' in extract_secret #1596

Merged
merged 4 commits into from
Jan 4, 2023
Merged

[r2r] validate input_tx is calling 'receiverSpend' in extract_secret #1596

merged 4 commits into from
Jan 4, 2023

Conversation

borngraced
Copy link
Member

Fixes: #1494
Signed-off-by: borngraced samiodev@icloud.com

@borngraced
validate input_tx is 'receiverSpend' in extract_secret
ed2ac96 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced borngraced self-assigned this Jan 2, 2023
@borngraced borngraced changed the title validate input_tx is calling 'receiverSpend' in extract_secret [r2r] validate input_tx is calling 'receiverSpend' in extract_secret Jan 2, 2023
@borngraced borngraced linked an issue Jan 3, 2023 that may be closed by this pull request
Check that input transaction is calling ReceiverSpend in eth::extract_secret. #1494
Closed
sergeyboyko0791
sergeyboyko0791 suggested changes Jan 3, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One minor change please

mm2src/coins/eth.rs Outdated Show resolved Hide resolved
@borngraced
minor changes
cf325f7 
Signed-off-by: borngraced <samiodev@icloud.com>
sergeyboyko0791
sergeyboyko0791 approved these changes Jan 3, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

artemii235
artemii235 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@artemii235 artemii235 merged commit 161b34b into dev Jan 4, 2023
@artemii235 artemii235 deleted the validate_ReceiverSpend_input_transaction branch January 4, 2023 14:34
@borngraced borngraced mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@artemii235 artemii235 artemii235 approved these changes

Assignees

@borngraced borngraced

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that input transaction is calling ReceiverSpend in eth::extract_secret.
3 participants
@borngraced @artemii235 @sergeyboyko0791