Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Fix WASM RPC handler #1620

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[r2r] Fix WASM RPC handler #1620

merged 1 commit into from
Jan 19, 2023

Conversation

sergeyboyko0791
Copy link

  • Spawn process_json_request so the RPC requests can be processed asynchronously

@sergeyboyko0791 sergeyboyko0791 changed the title Fix WASM RPC handler [r2r] Fix WASM RPC handler Jan 19, 2023
@sergeyboyko0791 sergeyboyko0791 linked an issue Jan 19, 2023 that may be closed by this pull request
Wasm timeout attempting certain pair trades #1616
Closed
@sergeyboyko0791
Copy link
Author

@smk762 Please test that this fixes #1616

artemii235
artemii235 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for the fast fix!

@smk762
Copy link

smk762 commented Jan 19, 2023

The fix is golden, thank you very much!
The atomicdex-play interface doesn't get locked up by spamming, I no longer face issues with some pairs in webdex, and the app feels more responsive overall. Great work 🔥

@artemii235 artemii235 merged commit 90ce38a into dev Jan 19, 2023
@artemii235 artemii235 deleted the improve-wasm-rpc branch January 19, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk762 smk762 smk762 approved these changes

@artemii235 artemii235 artemii235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm timeout attempting certain pair trades
3 participants
@sergeyboyko0791 @smk762 @artemii235