Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] Fix KMD withdraw with Trezor, add mm2_stop WASM FFI #1628

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

sergeyboyko0791
Copy link

@sergeyboyko0791 sergeyboyko0791 commented Jan 22, 2023

@sergeyboyko0791 sergeyboyko0791 linked an issue Jan 22, 2023 that may be closed by this pull request
@sergeyboyko0791 sergeyboyko0791 changed the title Set expiry for Zcash-based transactions [r2r] Set expiry for Zcash-based transactions Jan 22, 2023
@sergeyboyko0791 sergeyboyko0791 linked an issue Jan 22, 2023 that may be closed by this pull request
@sergeyboyko0791 sergeyboyko0791 changed the title [r2r] Set expiry for Zcash-based transactions [r2r] Fix KMD withdraw with Trezor, add mm2_stop WASM FFI Jan 23, 2023
@sergeyboyko0791 sergeyboyko0791 self-assigned this Jan 23, 2023
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One note.

mm2src/coins/utxo_signer/src/with_trezor.rs Show resolved Hide resolved
yurii-khi
yurii-khi previously approved these changes Jan 23, 2023
Copy link

@yurii-khi yurii-khi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, with this update problem is gone on webDEX side, thanks @sergeyboyko0791 !

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@artemii235 artemii235 merged commit 1086720 into dev Jan 23, 2023
@artemii235 artemii235 deleted the fix-kmd-coinbase-trezor branch January 23, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants