Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Multiple rpcs optimization #1653

Merged
merged 16 commits into from
Feb 15, 2023
Merged

[r2r] Multiple rpcs optimization #1653

merged 16 commits into from
Feb 15, 2023

Conversation

laruh
Copy link
Member

@laruh laruh commented Feb 12, 2023 •
edited
Loading

related to #1480

Multi rpcs optimizations were added in http_transport and z_rpc

Note about send_request in http_transport. I decided its better just to call rotate_left function, if request was successful, instead of building and sending request for health check and sending request again, when we got live client.

@laruh
wip
f224959
@laruh
use rotate_left in send_request (not wasm target)
98b9836
@laruh
use rotate_left in send_request (wasm target)
f0f16fb
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
0771a20 
…tion
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
fd743d1 
…tion
@laruh
wip impl RpcCommonOps for LightRpcClient
e8e98ee
@laruh
impl ZRpcOps for LightRpcClient
6dd88ba
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
e122f29 
…tion
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
a693db0 
…tion
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
877fdad 
…tion
@laruh
fix wasm
2661280
@laruh
Merge remote-tracking branch 'origin/dev' into multiple-rpcs-optimiza…
fec5b29 
…tion
@laruh
remove notes
4180d2c
@laruh
add empty line
93f3210
@laruh laruh changed the title Multiple rpcs optimization [r2r] Multiple rpcs optimization Feb 14, 2023
shamardy
shamardy previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this enhancement! Only one non-blocker unrelated to your code changes :)

mm2src/coins/z_coin/z_rpc.rs Outdated Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 previously approved these changes Feb 14, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

onur-ozkan
onur-ozkan previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small note

mm2src/coins/z_coin/z_rpc.rs Outdated Show resolved Hide resolved
shamardy
shamardy approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit fb04863 into dev Feb 15, 2023
@shamardy shamardy deleted the multiple-rpcs-optimization branch February 15, 2023 12:56
@laruh laruh mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 left review comments

@onur-ozkan onur-ozkan onur-ozkan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laruh @shamardy @onur-ozkan @sergeyboyko0791