Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] temp fix on cargo deny #1657

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[r2r] temp fix on cargo deny #1657

merged 1 commit into from
Feb 15, 2023

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Feb 15, 2023

wth happened in this last couple days, there are so many sec-advisory ids started failing in cargo deny...

I will start working on these by the following week. They should start getting fixed ASAP prioritized by their CVSS Score.

cc @ca333 @smk762

Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan onur-ozkan mentioned this pull request Feb 15, 2023
@onur-ozkan onur-ozkan changed the title temp fix on cargo deny [r2r] temp fix on cargo deny Feb 15, 2023
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fast fix. Only non-blockers!
I think we should also ignore the solana tests that keep failing since this protocol integration was not completed.

deny.toml Show resolved Hide resolved
@onur-ozkan
Copy link
Member Author

onur-ozkan commented Feb 15, 2023

I think we should also ignore the solana tests that keep failing since this protocol integration was not completed.

If we don't use any part of solana on gui side, I can do that

@shamardy
Copy link
Collaborator

If we don't use any part of solana on gui side

It's not found in the coins file, so I think it's not used. Only BEP20 and PLG20 versions are used.

@shamardy shamardy merged commit 69aff14 into dev Feb 15, 2023
@shamardy shamardy deleted the ignore-2023-0005 branch February 15, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants