Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for VirusTotal results #1676

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Add workflow for VirusTotal results #1676

merged 1 commit into from
Feb 25, 2023

Conversation

smk762
Copy link

@smk762 smk762 commented Feb 24, 2023

Closes #790

I've added my VirusTotal API key to github secrets for this repo.
Tested workflow in fork at https://github.com/smk762/atomicDEX-API/actions
Example results at https://github.com/smk762/atomicDEX-API/releases/tag/test

Current triggers will initiate workflow whenever a release is created, edited, prereleased or published. In testing, it was found that the VirusTotal results will append to the release body, which will result in duplicated VirusTotal results section if prior results not deleted.

We can limit the triggers, or just make sure to remove old results from the release body text when edits are made (e.g. file uploads, adding changelog etc).

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks legit, so I can approve the PR.

However, I am unsure how reliable the unofficial virus total extension is. We could also write this this easy with even adding more security checks in it.

@smk762
Copy link
Author

smk762 commented Feb 24, 2023

The diff looks legit, so I can approve the PR.

However, I am unsure how reliable the unofficial virus total extension is. We could also write this this easy with even adding more security checks in it.

I've done something similar for Desktop a while ago via python script and virustotal-python pip package, though it is a manual process.

Script has served well over the last year, though I had to add large file support initially. Repo maintainer was quick and on the ball.

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onur-ozkan
Copy link
Member

The diff looks legit, so I can approve the PR.
However, I am unsure how reliable the unofficial virus total extension is. We could also write this this easy with even adding more security checks in it.

I've done something similar for Desktop a while ago via python script and virustotal-python pip package, though it is a manual process.

Script has served well over the last year, though I had to add large file support initially. Repo maintainer was quick and on the ball.

I personally try to stay away as many dependencies as I can. I think virus total file scannning thing could be even done in a 30-40 lines of shell script(which can be used in any CI runner like gitlab, travis, etc).

I am fine with merging/using this. Later on we can create a detailed security analysis script that also checks for virus total. Until then, let's use this one.

@ca333 ca333 merged commit a6f9a0e into dev Feb 25, 2023
@ca333 ca333 deleted the vt_ci branch February 25, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants