Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Better error message for failing swaps due to a time difference between maker and taker #1677

Merged
merged 2 commits into from
Feb 24, 2023
Merged

[r2r] Better error message for failing swaps due to a time difference between maker and taker #1677

merged 2 commits into from
Feb 24, 2023

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy changed the title [wip] Better error message for failing swaps due to a time difference between maker and taker [r2r] Better error message for failing swaps due to a time difference between maker and taker Feb 24, 2023
@onur-ozkan
Copy link
Member

onur-ozkan commented Feb 24, 2023 •
edited
Loading

Can you also inform about the time diff cap? Something like The time difference between pairs can not be longer than 60 seconds. Current difference: {}. please make sure that your system clock is synced to the correct time before starting another swap!.

Also, you can create a dev-log file since we have them on dev branch with #1666 merge

@shamardy
Copy link
Collaborator Author

Also, you can create a dev-log file since we have them on dev branch with #1666 merge

Yeah, we should start doing that. Thanks for the reminder :)

onur-ozkan
onur-ozkan approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@shamardy shamardy merged commit d92ff60 into dev Feb 24, 2023
@shamardy shamardy deleted the bugfix-msg-time-diff branch February 24, 2023 21:38
@shamardy shamardy mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@cipig cipig cipig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamardy @onur-ozkan @cipig