[r2r] refactor version handling #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
ca333
reviewed
Mar 2, 2023
ca333
reviewed
Mar 2, 2023
ca333
reviewed
Mar 2, 2023
onur-ozkan
force-pushed
the
refactor-versioning
branch
from
295a7ba
to
8bf6c13
Compare
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
refactor-versioning
branch
2 times, most recently
from
d8910dd
to
6d41fd9
Compare
shamardy
previously approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MM_VERSIONto read version in a proper way--version,-v,versionargument now prints the mm2 versionI actually wanted to get rid of
MM_VERSIONcompletely, but I saw the required effort wasn't worth for it, it's too complicated to be removed from current pipelines, source code, etc. Because I have more important tasks, I decided to adapt it instead of refactoring it completely.