Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to KomodoPlatform repo for parity-ethereum and testcontainers-… #1690

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

DeckerSU
Copy link
Collaborator

@DeckerSU DeckerSU commented Mar 2, 2023

…rs crates

This PR introduce the following transition:

git+https://github.com/artemii235/parity-ethereum.git -> git+https://github.com/KomodoPlatform/mm2-parity-ethereum.git
git+https://github.com/artemii235/testcontainers-rs.git -> git+https://github.com/KomodoPlatform/mm2-testcontainers-rs.git

@cipig
Copy link
Member

cipig commented Mar 2, 2023

parity is actually discontinued, the original repo https://github.com/openethereum/parity-ethereum is archived and not updated any more... https://github.com/openethereum also shows that it's deprecated
RPC servers are now using https://github.com/ethereum/go-ethereum
idk what that means for the client part though, if there is a new repo somewhere, so just saying

@shamardy
Copy link
Collaborator

shamardy commented Mar 2, 2023

parity is actually discontinued, the original repo https://github.com/openethereum/parity-ethereum is archived and not updated any more... https://github.com/openethereum also shows that it's deprecated

If you check the fork you can see we only use 2 very small modified libraries from parity-ethereum. I think we should actually copy them into the API code like we did with the parity bitcoin fork before, but this can be done in another PR. We also use rust-web3 fork which is still maintained.

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit ec6d028 into KomodoPlatform:dev Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants