Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] update testnet node of atom #1692

Merged
merged 4 commits into from
Mar 6, 2023
Merged

[r2r] update testnet node of atom #1692

merged 4 commits into from
Mar 6, 2023

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented Mar 3, 2023

We have failing tests due to the used cosmos testnet node, tests are ignored for now until we find another working node or get this node to work again.

@shamardy shamardy changed the title [wip] Ignore atom tests for now [r2r] Ignore atom tests for now Mar 3, 2023
@shamardy shamardy requested a review from onur-ozkan March 3, 2023 14:46
@shamardy shamardy changed the title [r2r] Ignore atom tests for now [wip] Ignore atom tests for now Mar 3, 2023
@shamardy shamardy changed the title [wip] Ignore atom tests for now [r2r] Ignore atom tests for now Mar 3, 2023
onur-ozkan
onur-ozkan previously approved these changes Mar 3, 2023
View reviewed changes
@onur-ozkan
Copy link
Member

You can hard reset this PR to dev branch and cherry-pick b0908d5

@onur-ozkan @shamardy
update testnet node of atom
cdc2d83 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@shamardy shamardy changed the title [r2r] Ignore atom tests for now [r2r] update testnet node of atom Mar 6, 2023
onur-ozkan
onur-ozkan previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another vulnerable dep:(

@shamardy
Copy link
Collaborator Author

shamardy commented Mar 6, 2023

another vulnerable dep:(

Ignored it for now, it's related to prost-build and solana crates. It's won't be easy to fix/update but will look into it more.

@shamardy
Copy link
Collaborator Author

shamardy commented Mar 6, 2023

More about the vulnerable dep, it's related to tempfile crate that is used in solana crates and prost-build. It was fixed here Stebalien/tempfile#208 but not released yet, also needs to be updated in the solana and prost-build repos first before we can update them. I don't think it affects us though, since solana is not used and prost-build is a build dependency only.
@ozkanonur can you please re-approve so I can merge this?

onur-ozkan
onur-ozkan reviewed Mar 6, 2023
View reviewed changes
deny.toml Outdated
{ name = "windows_i686_msvc", version = "*" },
{ name = "windows-sys", version = "*" },
{ name = "windows_x86_64_msvc", version = "*" },
{ name = "windows_x86_64_gnu", version = "*" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these needed anymore since we ignored the vul ID already?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed, but they were cluttering the Cargo deny checks CI log

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they don't fail the pipeline, let's remove these

I will do more work on vulnerable dependencies this week

@shamardy shamardy merged commit b6a9c92 into dev Mar 6, 2023
@shamardy shamardy deleted the bugfix-ignore-atom-tests branch March 6, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamardy @onur-ozkan