Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] change release branch from mm2.1 to main #1697

Merged
merged 3 commits into from
Mar 8, 2023
Merged

[ci] change release branch from mm2.1 to main #1697

merged 3 commits into from
Mar 8, 2023

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented Mar 6, 2023

No description provided.

@shamardy shamardy changed the title Change release branch from mm2.1 to main [ci] change release branch from mm2.1 to main Mar 6, 2023
onur-ozkan
onur-ozkan reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace all mm2.1 usages in other modules like eth.rs? We shouldn't have that anywhere in source code

@shamardy shamardy requested a review from onur-ozkan March 7, 2023 13:44
onur-ozkan
onur-ozkan previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy
ci: disable mac ci steps (#1701)
091b3e9 
Reviewed-by: ozkanonur <work@onurozkan.dev>
@shamardy shamardy requested review from ca333 and removed request for ca333 March 8, 2023 14:37
@shamardy shamardy merged commit ebbd5d2 into main Mar 8, 2023
@shamardy shamardy deleted the ci-change-release-branch branch March 8, 2023 14:39
shamardy added a commit that referenced this pull request Mar 15, 2023
@ca333 @shamardy
docs: resolve changelog conflict (#1707)
be5503f 
* [ci] change release branch from mm2.1 to main (#1697)

* change release branch from mm2.1 to main

* replace mm2.1 to main in eth_tests

* ci: disable mac ci steps (#1701)

Reviewed-by: ozkanonur <work@onurozkan.dev>

* docs: introduce CHANGELOG.md (#1680)

* propose change.log

add a chronological "living" changelog file as a index for the dev.logs

* introduce CHANGELOG.md

* [docs] update changelog

* [docs] add changelog date/tag

* update changelog

* update date

* re-enable mac ci, add one more change log

---------

Co-authored-by: shamardy <shamardy@yahoo.com>
Reviewed-by: ozkanonur <work@onurozkan.dev>, shamardy <shamardy@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@ca333 ca333 Awaiting requested review from ca333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamardy @onur-ozkan