get rid of crossterm and crates dependent on it #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
reviewed
Mar 13, 2023
onur-ozkan
previously approved these changes
Mar 14, 2023
|
@DeckerSU can you please merge with the latest |
DeckerSU
force-pushed
the
patch-get-rid-of-crossterm
branch
from
8acf983
to
8bcd4d7
Compare
Co-authored-by: Onur <onurozkan.dev@outlook.com>
shamardy
approved these changes
Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the purpose of this PR is to get rid of almost unused
crosstermdependency (it used only for colored log files output in tests) and couple of other "old" unneeded dependencies in tree, such ascrossterm_winapi,mio 0.7.13,miow,ntapi,signal-hook,signal-hook-mio.