call eth_getTransactionByHash in wait_for_confirmations to avoid race condition #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it will be returned in swap payment validation
cipig
previously approved these changes
Mar 15, 2023
There was a problem hiding this comment.
thanks a lot, works perfectly:
| (0:00/51:40) [EURS-PLG20] Waiting for confirmations…
15 08:03:57, coins:eth:1814] ERROR Didn't find tx: d07eb2df6a0d349f27345d25b1332b61e4805960b59a25ad1fd341958eac272c for coin: EURS-PLG20 on RPC node using eth_getTransactionByHash. Retrying in 15 seconds
+--- 15 08:04:06 -------
| (0:42) [swap uuid=40d0d532-dc9a-4e24-8864-a568ed334822] Maker payment wait confirm started...
| (0:24/51:40) [EURS-PLG20] Waiting for confirmations…
· 2023-03-15 08:04:12 +0000 [EURS-PLG20] Waiting for confirmations… Confirmed.
15 08:04:12, taker_swap:1343] INFO After wait confirm
|
mention about this fix in the changelog so we can merge this @shamardy |
caglaryucekaya
previously approved these changes
Mar 15, 2023
shamardy
dismissed stale reviews from caglaryucekaya, cipig, and onur-ozkan
via
99473be
Done |
cipig
approved these changes
Mar 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1630. For more info. #1630 (comment)