stream stdout/err to a file

[onur-ozkan]

refactors native_log and implements stdout/err streaming to persistent file without dependencies

removed dependencies from dependency tree:

• arc-swap@0.4.8
• log-mdc@0.1.0
• thread-id@3.3.0
• log4rs@1.0.0
• env_logger@0.7.1
• humantime@1.3.0

ref #1749 (comment)

[cipig]

CLI works fine, as before the change
on ADEX Desktop, the logfile works too
some entries are duplicated, shown in log and on console, like this ones during a swap

10 15:32:47, mm2_main::mm2::lp_swap::taker_swap:2425] WARN taker_swap:2478] utxo_common:3362] utxo_common:936] Not enough RVN for swap: available 0, required at least 0.00001, locked by swaps None
10 15:32:48, mm2_main::mm2::lp_swap::taker_swap:1327] INFO Got maker payment 5f175b31a67207fed87a043bacf3f7c8253f3a1147a164882e1165618898e34a
10 15:32:48, mm2_main::mm2::lp_swap::taker_swap:1340] INFO Before wait confirm

is that intentionally?
i am running an ADEX Desktop debug build, will test with a release build, idk if it makes a difference

[cipig]

it's the same on the release build of ADEX Desktop, the entries are written to the logfile, but also showed on console

[onur-ozkan]

Stdout/err is directly streamed into the log file, whatever you see on the terminal is also in the log file. Specially for users who's deploying lots of mm2 on server, you can't track all the terminals up-to-bottom. So you will be able to search in files which I believe much easier.

Was this different before? Didn't we already write the terminal logs into the file before?

[cipig]

ADEX Desktop handles his own logs like this atm:

• the debug build shows it on console and writes it to file
• the release build only writes it to file

that is for his own logs, not from mm2

the stuff from mm2 is shown on console and written to the file, on both debug and release builds of Desktop
Desktop starts mm2 with the logfile param set for mm2

on pure CLI, i don't use the logfile param from mm2, i simply redirect the console output to file... i have done it like this before and haven't changed anything... this works like it was before, no change, all good

[cipig]

how is it meant to be? when i set logfile in mm2... should the output be duplicated on console and log file?... or should it be only in log file? atm it's on both

if it's meant to be on both, then it's fine and works as designed

[onur-ozkan]

how is it meant to be? when i set logfile in mm2... should the output be duplicated on console and log file?... or should it be only in log file? atm it's on both

if it's meant to be on both, then it's fine and works as designed

When you set the MM_LOG, the stdout and stderr will be written in the file you specify in MM_LOG. If you want to make your terminal clean/empty and write the logs only on the file, I can add a parameter to mm conf, like silent_console, which will prevent writing logs to the terminal. Do you want me to do that?

[onur-ozkan]

The logging implementation on mm2 is quite complicated and chaotic I would say. And I am trying to adapt it to the common/best practices. Ofc without breaking the mm2 clients. So if you want to keep the terminal clean and write logs to the log file, I will have to add another parameter to the mm2 conf(the file you give to MM_CONF_PATH).

[onur-ozkan]

With 861ce8e you will be able to keep the console empty and write the logs to the file. If you don't enable file logging and make silent_console true, there will be no logging anywhere. silent_console is false as a default, which can be enabled anytime from configuration file.

Let me know if this does what desktop client needs @cipig

[cipig]

Let me know if this does what desktop client needs

I actually don't know what Desktop app wants. But if there is a choice it's perfect, they can decide and configure accordingly.
I saw that console output was completely removed from Desktop release builds, so i thought that having suddenly mm2 output on console would be counterproductive.

[onur-ozkan]

With 861ce8e you will be able to keep the console empty and write the logs to the file. If you don't enable file logging and make silent_console true, there will be no logging anywhere. silent_console is false as a default, which can be enabled anytime from configuration file.

I think silent_console should be documented once this PR is merged

cc @yurii-khi @smk762

[shamardy]

Thanks a lot for the refactor! only one small comment.