use OS generated secrets #1753
Merged
use OS generated secrets #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
force-pushed
the
os_rng
branch
2 times, most recently
from
7d74fce
to
9aa583d
Compare
shamardy
reviewed
Apr 19, 2023
shamardy
previously approved these changes
Apr 20, 2023
|
@Alrighttt can you please check if this PR fixes the issue? |
Signed-off-by: ozkanonur <work@onurozkan.dev>
|
Sorry for the delay. Consider this me signing off for approval. I will add manual testing of this to my backlog of tasks. It's unlikely we would ever fail to generate a secret, but I am curious to know when exactly that scenario is possible. I would like to investigate how this could impact various platforms. |
#1753 (comment), but even failing to generate a secret won't cause any problems since the swap won't start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use OS generated secrets in
maker_swapandtendermint_coin::get_sender_trade_fee_for_denomto achieve cryptographically secure randomness