active/passive modes for parent coins #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
added
in progress
onur-ozkan
force-pushed
the
passive-coin-state
branch
3 times, most recently
from
6b6c4ed
to
ffdec19
Compare
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
passive-coin-state
branch
from
ffdec19
to
d84eb7f
Compare
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
passive-coin-state
branch
from
2daaeb8
to
f827e98
Compare
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
passive-coin-state
branch
2 times, most recently
from
aefca72
to
b8ed77c
Compare
onur-ozkan
added
under review
and removed
in progress
onur-ozkan
commented
May 3, 2023
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
passive-coin-state
branch
from
b8ed77c
to
57be79e
Compare
|
I ran a few tests using the web GUI, and everything is working smoothly so far without any changes on our side. Thanks, @ozkanonur ! |
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
passive-coin-state
branch
from
560fa43
to
a4ffaa0
Compare
shamardy
reviewed
May 3, 2023
Signed-off-by: ozkanonur <work@onurozkan.dev>
shamardy
previously approved these changes
May 4, 2023
Signed-off-by: ozkanonur <work@onurozkan.dev>
Merged
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
|
@caglaryucekaya did you approve this PR, or are you doing another review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings active/passive modes for parent coins which aims to keep children token states in memory when
disable_coinis executed for parent coin.Progress:
is_availableatomic flag,is_availableandupdate_is_availableto coins context.is_availableandupdate_is_availableon certain conditions around coin activations anddisable_coin.is_availabletotrueon re-activation.implementaddforce_disable_allRPC to drop everything on target coin.force_disableflag todisable_coinRPCmm2_test_helpers::for_tests::disable_coin_errpassivizedflag ondisable_coinRPC responseBreaking Changes:
dependent_tokensis removed from the RPC response. Because we no longer care about if there are active tokens or not.--
Docs for GUI:
cc @yurii-khi @KomodoPlatform/qa
new param
force_disable: bool(false as default)fordisable_coinRPC request payloadtrue, if platform has tokens enabled,disable_coinwill passive the platform coin with keeping all the tokens active and usable. Whenforce_disableistrue, no matter if platform passive, or active, it will be disabled with all it's tokens.new field
passivizedondisable_coinRPC responseforce_disablepassivized coins to disable all tokens and drop swaps which is faster in terms of UX)When passive coin is re-activated, it only changes it's passive status(and activates the tokens if enabled with tokens) without updating the other fields like rpc urls, tx history, etc. If these fields needs to be changed, the coin must be disabled with
force_disableflag which cleans up the memory from that platform.--
Resolves #1641