fix get_receiver_trade_fee for cosmos
#1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
fix-cosmos-swap-fees
branch
from
6f51bf8
to
5381cff
Compare
onur-ozkan
changed the title
get_receiver_trade_fee for cosmos
cipig
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_amount: BigDecimalparameter was initially added for calculating receiver trade fee in cosmos swaps.As it's been explained with the comments here:
https://github.com/KomodoPlatform/atomicDEX-API/blob/547a30a79b16da38769411772d837548922ee529/mm2src/coins/tendermint/tendermint_coin.rs#L1994-L1997
We are trying to simulate create HTLC transactions with the received amount, which causes tx errors if the sender sends more amount than what cosmos address has.
Because htlc amount doesn't increase the gas fee, I decided to remove that send amount parameter and use the minimum tx amount instead.
ref txs with different amounts and close gas fees: