Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nft): introduce db cache support (non-wasm target) #1833

Merged
merged 84 commits into from
Jun 21, 2023
Merged

feat(nft): introduce db cache support (non-wasm target) #1833

merged 84 commits into from
Jun 21, 2023

Conversation

laruh
Copy link
Member

@laruh laruh commented May 22, 2023 •
edited
Loading

#900
Current version of nft cache support includes implemented sqlite db and todos for wasm target, but it covers the general logic for both targets.

gist with docs

laruh added 30 commits April 3, 2023 14:56
@laruh
draft
7a62de0
@laruh
wip
350f1d5
@laruh
wip
08ba26c
@laruh
wip
7d0edf1
@laruh
remove StorageFactory
5df609e
@laruh
add wasm target in NftStorageBuilder::build
b0d965f
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
6d12a42
@laruh
add StorageOps todos
6d84038
@laruh
impl trait err for target err
9ef02b7
@laruh
change functions in Ops
67133a2
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
f935e5a
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
f249593
@laruh
wasm: add lock_db fn and From IDB errors
2d66f8f
@laruh
wasm: change name
9225e99
@laruh
sql: table names
9f977f3
@laruh
sql: save create table commands
de5cff6
@laruh
sql: init fnc
65c702b
@laruh
sql: is_initialized_for fnc
52b3c32
@laruh
remove wip, leave draft
6d34df5
@laruh
add possible_spam
9bf6453
@laruh
unite traits
0a19dba
@laruh
fmt
9e2b935
@laruh
wip
8349de1
@laruh
save wip state, moralis was removed from get_nft_list
d2e0653
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
3e5cd51
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
7ba5c30
@laruh
save state
64fa485
@laruh
Merge remote-tracking branch 'origin/dev' into add-nft-cache-support
b37f9a8
@laruh
get_nft_list with storage
844c9e5
@laruh
add get_nft method
d9c36a5
@shamardy
Copy link
Collaborator

@laruh is this ready for review again?

@laruh laruh added under review and removed in progress Changes will be made from the author labels Jun 15, 2023
@laruh
Copy link
Member Author

laruh commented Jun 15, 2023

@laruh is this ready for review again?

Yes, sorry I forgot to change the label

shamardy
shamardy reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more last review notes for the latest changes

mm2src/coins/nft.rs Outdated Show resolved Hide resolved
mm2src/coins/nft.rs Outdated Show resolved Hide resolved
mm2src/coins/nft.rs Outdated Show resolved Hide resolved
mm2src/coins/nft/nft_errors.rs Outdated Show resolved Hide resolved
@laruh laruh added in progress Changes will be made from the author and removed under review labels Jun 16, 2023
@laruh laruh added under review and removed in progress Changes will be made from the author labels Jun 16, 2023
shamardy
shamardy previously approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shamardy shamardy added the P1 label Jun 20, 2023
@shamardy
Copy link
Collaborator

@ozkanonur @borngraced can you please do your final reviews for this PR, it should be part of the next release.

onur-ozkan
onur-ozkan previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocker note

mm2src/common/common.rs Outdated Show resolved Hide resolved
borngraced
borngraced requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! couple notes please

mm2src/coins/nft/nft_errors.rs Outdated Show resolved Hide resolved
mm2src/coins/nft/nft_errors.rs Outdated Show resolved Hide resolved
mm2src/coins/nft/storage/mod.rs Outdated Show resolved Hide resolved
mm2src/coins/nft/storage/wasm/wasm_storage.rs Show resolved Hide resolved
mm2src/coins/nft/nft_errors.rs Outdated Show resolved Hide resolved
mm2src/coins/nft/storage/wasm/mod.rs Show resolved Hide resolved
@laruh laruh added in progress Changes will be made from the author and removed under review labels Jun 21, 2023
@laruh laruh dismissed stale reviews from onur-ozkan and shamardy via 0761425 June 21, 2023 05:46
@laruh laruh added under review and removed in progress Changes will be made from the author labels Jun 21, 2023
@shamardy shamardy merged commit 26ee4e8 into dev Jun 21, 2023
@shamardy shamardy deleted the add-nft-cache-support branch June 21, 2023 21:10
@shamardy shamardy mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borngraced borngraced borngraced requested changes

@shamardy shamardy shamardy approved these changes

@onur-ozkan onur-ozkan onur-ozkan left review comments

@rozhkovdmitrii rozhkovdmitrii Awaiting requested review from rozhkovdmitrii

Assignees
No one assigned
Labels
P1 under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laruh @onur-ozkan @shamardy @borngraced