Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): remove config string from deserialization error log #1872

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

shamardy
Copy link
Collaborator

Copy link

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@onur-ozkan
Copy link
Member

What does error message from serde print? Does it print the invalid line or the whole configuration?

@onur-ozkan
Copy link
Member

11 13:22:21, mm2:281] mm2:307] Couldn't parse.({
  "gui":"CLI",
  "netid":7777,
  "rpc_password":"lets-just-pretend-this-is-my-rpcpass",
  "passphrase":"not really my seed but something was here in clear text",
}
).trailing comma at line 6 column 1

as far as I see it's the trailing comma at line 6 column 1 part and I think it would be useful to have in the error message

@shamardy
Copy link
Collaborator Author

as far as I see it's the trailing comma at line 6 column 1 part and I think it would be useful to have in the error message

I agree that this is useful but future changes in the upstream could lead to showing the passed config string. For instance, if they decide to provide more verbose errors that include more information about the passed string, we might inadvertently expose this data again. I don't want to leave it to that chance since we will probably forget to check this with every update to the upstream dependency.

@shamardy shamardy merged commit 5917533 into dev Jun 21, 2023
@shamardy shamardy deleted the fix-conf-log branch June 21, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants