Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(adex-cli): orderbook response processing moved #1879

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

rozhkovdmitrii
Copy link

To facilitate the future review I present a refactoring part in the standalone PR. This refactoring is actually just moving orderbook mod, that was structured as response_handler internal one out into the related folder

@laruh
Copy link
Member

laruh commented Jun 23, 2023

@rozhkovdmitrii Please fix PR Lint / Validate title and the typo )

UPD and please set under review label if its r2r

@rozhkovdmitrii rozhkovdmitrii changed the title refactor: Еhe orderbook processing functionality has been moved refactor: The orderbook processing functionality has been moved Jun 23, 2023
@rozhkovdmitrii rozhkovdmitrii changed the title refactor: The orderbook processing functionality has been moved refactor(adex-cli): The orderbook processing functionality has been moved Jun 23, 2023
@rozhkovdmitrii rozhkovdmitrii linked an issue Jun 23, 2023 that may be closed by this pull request
10 tasks
@rozhkovdmitrii rozhkovdmitrii changed the title refactor(adex-cli): The orderbook processing functionality has been moved refactor(adex-cli): The orderbook response processing moved Jun 23, 2023
@rozhkovdmitrii rozhkovdmitrii changed the title refactor(adex-cli): The orderbook response processing moved refactor(adex-cli): Orderbook response processing moved Jun 23, 2023
@rozhkovdmitrii rozhkovdmitrii changed the title refactor(adex-cli): Orderbook response processing moved refactor(adex-cli): orderbook response processing moved Jun 23, 2023
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit 24f35b4 into dev Jun 26, 2023
@shamardy shamardy deleted the 1798-restructure-adex-cli-code branch June 26, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement all legacy order management comands as a part of adex-cli
3 participants