Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adex-cli): fix bug start without config #1889

Merged
merged 9 commits into from
Jun 30, 2023
Merged

fix(adex-cli): fix bug start without config #1889

merged 9 commits into from
Jun 30, 2023

Conversation

rozhkovdmitrii
Copy link

adex-cli had a bug:

It was impossible to start if configuration does not exist, that has been fixed.

@rozhkovdmitrii rozhkovdmitrii added the bug Something isn't working label Jun 28, 2023
@rozhkovdmitrii rozhkovdmitrii self-assigned this Jun 28, 2023
@rozhkovdmitrii rozhkovdmitrii marked this pull request as ready for review June 28, 2023 10:51
@rozhkovdmitrii rozhkovdmitrii added under review blocked requires additional attention P1 and removed blocked requires additional attention labels Jun 28, 2023
@rozhkovdmitrii rozhkovdmitrii force-pushed the 1786-fix-bug-start-without-config branch 2 times, most recently from 47ca1fa to 5482d16 Compare June 28, 2023 13:12
@rozhkovdmitrii rozhkovdmitrii force-pushed the 1786-fix-bug-start-without-config branch from 5482d16 to efd1a37 Compare June 28, 2023 13:16
shamardy
shamardy reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! I have 2 small comments.
Please also fix the fmt errors in CI.

mm2src/adex_cli/src/adex_app.rs Show resolved Hide resolved
mm2src/adex_cli/src/adex_proc/command.rs Outdated Show resolved Hide resolved
shamardy
shamardy approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit e6bc207 into dev Jun 30, 2023
@shamardy shamardy deleted the 1786-fix-bug-start-without-config branch June 30, 2023 02:14
laruh pushed a commit that referenced this pull request Jul 6, 2023
@rozhkovdmitrii @laruh
fix(adex-cli): fix bug when starting without config (#1889)
ec30325 
This commit fixes a bug where it was impossible to start adex-cli if configuration does not exist.
@shamardy shamardy mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@onur-ozkan onur-ozkan Awaiting requested review from onur-ozkan

Assignees

@rozhkovdmitrii rozhkovdmitrii

Labels
bug Something isn't working P1 under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozhkovdmitrii @shamardy