Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all Swap parameters at the Negotiation stage #1458

Closed
sergeyboyko0791 opened this issue Sep 2, 2022 · 6 comments
Closed

Validate all Swap parameters at the Negotiation stage #1458

sergeyboyko0791 opened this issue Sep 2, 2022 · 6 comments
Assignees

Comments

@sergeyboyko0791
Copy link

@cipig
Copy link
Member

cipig commented Sep 2, 2022

Can the contract address of the involved tokens be checked too? Making sure it's the same on maker and taker.
For UTXO coins "pubtype", "p2shtype" and "wiftype" from coins file could be used.

@sergeyboyko0791
Copy link
Author

We check the contract address already at the negotiate_swap_contract_address method.

Can the contract address of the involved tokens be checked too? Making sure it's the same on maker and taker.

Probably, we could validate them as well.

For UTXO coins "pubtype", "p2shtype" and "wiftype" from coins file could be used.

@cipig
Copy link
Member

cipig commented Sep 2, 2022

We check the contract address already at the negotiate_swap_contract_address method.

That is the swap contract address, not the contract address of the involved tokens. I meant to check if https://bscscan.com/token/0x8ac76a51cc950d9822d68b83fe1ad97b32cd580d for USDC-BEP20 is the same on maker and taker before starting a swap with USDC-BEP20 between the 2.

@sergeyboyko0791
Copy link
Author

Oh you're right. I think it would be great to check the contract addresses as well.

@borngraced
Copy link
Member

borngraced commented Sep 30, 2022

@cipig we'll be postponing _validating token address_ as there are some other requirements that needs to be met before implementing this check...I'll update on the progress here

@sergeyboyko0791
Copy link
Author

Close as solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants