-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate all Swap parameters at the Negotiation stage #1458
Comments
Can the contract address of the involved tokens be checked too? Making sure it's the same on maker and taker. |
We check the contract address already at the negotiate_swap_contract_address method.
Probably, we could validate them as well.
|
That is the swap contract address, not the contract address of the involved tokens. I meant to check if https://bscscan.com/token/0x8ac76a51cc950d9822d68b83fe1ad97b32cd580d for USDC-BEP20 is the same on maker and taker before starting a swap with USDC-BEP20 between the 2. |
Oh you're right. I think it would be great to check the contract addresses as well. |
@cipig we'll be postponing |
Close as solved |
The text was updated successfully, but these errors were encountered: