Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task::*::cancel doesn't work properly if the RPC task is in an awaiting status. #1580

Closed
sergeyboyko0791 opened this issue Dec 20, 2022 · 2 comments · Fixed by #1582
Closed

task::*::cancel doesn't work properly if the RPC task is in an awaiting status. #1580

sergeyboyko0791 opened this issue Dec 20, 2022 · 2 comments · Fixed by #1582
Assignees
@sergeyboyko0791
Labels
bug Something isn't working

Comments

@sergeyboyko0791
Copy link

Ref: KomodoPlatform/developer-docs#392 (comment)
@sergeyboyko0791 sergeyboyko0791 self-assigned this Dec 20, 2022
@sergeyboyko0791 sergeyboyko0791 added the bug Something isn't working label Dec 20, 2022
@sergeyboyko0791 sergeyboyko0791 linked a pull request Dec 20, 2022 that will close this issue
[r2r] Fix task::*::cancel if the RPC task is an awaiting status #1582
Merged
@artemii235
Copy link
Member

@sergeyboyko0791 Do we need additional testing on this, or it can be closed?

@sergeyboyko0791
Copy link
Author

I believe @smk762 has tested the changes #1582 (comment). I hope there is no reason to additionally test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyboyko0791 sergeyboyko0791

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[r2r] Fix task::*::cancel if the RPC task is an awaiting status KomodoPlatform/komodo-defi-framework
2 participants
@artemii235 @sergeyboyko0791