Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLP Tokens does not activate after deactivation #1667

Closed
ologunB opened this issue Feb 20, 2023 · 4 comments
Closed

SLP Tokens does not activate after deactivation #1667

ologunB opened this issue Feb 20, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ologunB
Copy link

ologunB commented Feb 20, 2023

Describe the bug
When an SLP Token(ASLP) is activated, then deactivated afterwards, on trying to activate again, it returns the error {"mmrpc":"2.0","error":"Abortable system has been aborted already","error_path":"token.slp","error_trace":"token:136] slp:309]","error_type":"Internal","error_data":"Abortable system has been aborted already","id":null}

It works on old mm2 version(37b6dbc) but returns the error in all latest mm2 versions in http://195.201.0.6/dev/

@shamardy
Copy link
Collaborator

Thanks for the bug report @ologunB
@borngraced can you please check what the problem is? I think this might be related to this PR #1525

@shamardy shamardy added the bug Something isn't working label Feb 20, 2023
This was referenced Feb 20, 2023
@borngraced
Copy link
Member

borngraced commented Feb 20, 2023

thanks for the report @ologunB,

@shamardy there was a bug in SlpToken::on_disable() when I implemented the feature, on_disable to abort coin related futures on deactivation.
https://github.com/KomodoPlatform/atomicDEX-API/blob/11a7347edcb9bf2de656b1b0ebc0f671d11cb9e3/mm2src/coins/utxo/slp.rs#L1875.

here's the pr for this fix #1670

@shamardy
Copy link
Collaborator

@ologunB can you please confirm if the bug is fixed in the latest dev?

@ologunB
Copy link
Author

ologunB commented Feb 21, 2023

@ologunB can you please confirm if the bug is fixed in the latest dev?

Works now. Closing this

@ologunB ologunB closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants