Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx fees are extra high for Atom transactions #1847

Closed
tonymorony opened this issue Nov 8, 2022 · 9 comments
Closed

Tx fees are extra high for Atom transactions #1847

tonymorony opened this issue Nov 8, 2022 · 9 comments
Assignees

Comments

@tonymorony
Copy link

[ cc @ozkanonur ]

Adex:
image

Kelpr:
image

@onur-ozkan
Copy link
Member

Could you lower the gas price in coins config and try again? Fee calculation uses gas price from coins config.

@onur-ozkan
Copy link
Member

We simulate the transaction and get the used gas from rpc node, and multiply it with the gas price. So the final fee amount can be anything depending on the gas price. Cosmos don't provide gas prices from rpc node, sadly we have to provide this value for each platform coins in cosmos.

@tonymorony tonymorony transferred this issue from KomodoPlatform/komodo-defi-framework Nov 12, 2022
@tonymorony
Copy link
Author

thank you for clarification @ozkanonur!
since rn this problem can be solved only by assets configuration moved it into assets configuration repo

@tonymorony tonymorony self-assigned this Nov 12, 2022
@tonymorony tonymorony transferred this issue from KomodoPlatform/coins May 30, 2023
@tonymorony tonymorony added the P0 label May 30, 2023
@tonymorony tonymorony assigned ca333 and unassigned tonymorony May 30, 2023
@tonymorony
Copy link
Author

bumping this one since fees still hardcoded for Atom/IRIS and it's not competitive at all with Kelpr = not really usable

@onur-ozkan
Copy link
Member

Could you lower the gas price in coins config and try again? Fee calculation uses gas price from coins config.

☝️

@onur-ozkan
Copy link
Member

It's not completely hard-coded

@onur-ozkan
Copy link
Member

I check the keplr sources, and saw this https://github.com/chainapsis/keplr-chain-registry/blob/f00637a3b9b8831043f64b87486d08fcea8e524d/cosmos/irishub.json#L48-L52 which means they are providing gas prices from the configuration files too.

@shamardy
Copy link
Collaborator

I check the keplr sources, and saw this https://github.com/chainapsis/keplr-chain-registry/blob/f00637a3b9b8831043f64b87486d08fcea8e524d/cosmos/irishub.json#L48-L52 which means they are providing gas prices from the configuration files too.

After discussion with @tonymorony and @yurii-khi we agreed that for this issue we need to have the ability for tendermint coin fees from config to be overridden in every withdraw call using WithdrawFee similar to how it works for UTXO and EVM.

For having 3 levels for fees (low priority, default/normal priority, high priority) and other enhancements, it will be done as part of #1848 (comment) later for all coins.

@onur-ozkan
Copy link
Member

Feel free to re-open this and ping me if there are any issues with #1894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants