-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx fees are extra high for Atom transactions #1847
Comments
Could you lower the gas price in coins config and try again? Fee calculation uses gas price from coins config. |
We simulate the transaction and get the used gas from rpc node, and multiply it with the gas price. So the final fee amount can be anything depending on the gas price. Cosmos don't provide gas prices from rpc node, sadly we have to provide this value for each platform coins in cosmos. |
thank you for clarification @ozkanonur! |
bumping this one since fees still hardcoded for Atom/IRIS and it's not competitive at all with Kelpr = not really usable |
☝️ |
It's not completely hard-coded |
I check the keplr sources, and saw this https://github.com/chainapsis/keplr-chain-registry/blob/f00637a3b9b8831043f64b87486d08fcea8e524d/cosmos/irishub.json#L48-L52 which means they are providing gas prices from the configuration files too. |
After discussion with @tonymorony and @yurii-khi we agreed that for this issue we need to have the ability for tendermint coin fees from config to be overridden in every withdraw call using WithdrawFee similar to how it works for UTXO and EVM. For having 3 levels for fees (low priority, default/normal priority, high priority) and other enhancements, it will be done as part of #1848 (comment) later for all coins. |
Feel free to re-open this and ping me if there are any issues with #1894 |
[ cc @ozkanonur ]
Adex:
![image](https://user-images.githubusercontent.com/24797699/200596944-6ce2cd8e-dca2-46c3-b388-dad3d2661c22.png)
Kelpr:
![image](https://user-images.githubusercontent.com/24797699/200596851-f96b542b-1837-4a96-922d-c940f338bfbe.png)
The text was updated successfully, but these errors were encountered: