Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Include usd_value for fee objects in swap json #1950

Open
smk762 opened this issue Aug 27, 2023 · 0 comments
Open

[FR] Include usd_value for fee objects in swap json #1950

smk762 opened this issue Aug 27, 2023 · 0 comments
Assignees

Comments

@smk762
Copy link

smk762 commented Aug 27, 2023

Describe the bug
Currently swap json includes the fields below:

  • Maker side:
				"maker_payment_trade_fee": {
					"coin": "MATIC",
					"amount": "0.086079675",
					"paid_from_trading_vol": false
				},
				"taker_payment_spend_trade_fee": {
					"coin": "KMD",
					"amount": "0.00001",
					"paid_from_trading_vol": true
				},

Taker side:


				"fee_to_send_taker_fee": {
					"coin": "KMD",
					"amount": "0.00001",
					"paid_from_trading_vol": false
				},
				"taker_payment_trade_fee": {
					"coin": "KMD",
					"amount": "0.00001",
					"paid_from_trading_vol": false
				},
				"maker_payment_spend_trade_fee": {
					"coin": "MATIC",
					"amount": "0.03149284582455",
					"paid_from_trading_vol": false
				},

There is also data regarding price of the coins being traded:

	"maker_amount": "0.691555176499475",
	"maker_coin": "CRV-PLG20",
	"maker_coin_usd_price": "0.657",
	"taker_amount": "2.1882427358927014028467925",
	"taker_coin": "KMD",
	"taker_coin_usd_price": "0.2077",

When the fee coin is not the same as the coins being traded (e.g. when trading evm tokens and paying gas in parent coin) there is no data available for the usd price of the fee coin at time of trade.

Including this information would enhance the ability to more accurately determine the total fiat cost of a trade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants