[FR] Include gui and version columns in MM2.db

[smk762]

The stats_swaps table currently contains only the columns listed at https://developers.komodoplatform.com/basic-docs/atomicdex/atomicdex-tutorials/query-the-mm2-database.html#stats-swaps

To derive the app gui and api version, we have to refer to the swap json files for each uuid on seed node servers. It would be nice to add columns for

• taker_gui
• maker_gui
• taker_version
• maker_version

[mariocynicys]

Should each side of the swap store its own gui and version only and have the seed node assemble them together?

Or should we poll the other party's gui and version and store/retrieve it from [M|T]akerSavedSwap? cc/ @shamardy

[shamardy]

Should each side of the swap store its own gui and version only and have the seed node assemble them together?

Yes, considering we currently don't have a way to fetch the other side's gui and version without altering the swap messages or adding new ones, it's fine for each side to keep their own gui and version. The seed nodes can then put the two together as you noted.

[shamardy]

Yes, considering we currently don't have a way to fetch the other side's gui and version without altering the swap messages or adding new ones, it's fine for each side to keep their own gui and version. The seed nodes can then put the two together as you noted.

Please note that for non-wasm light nodes (clients), they process swap status messages same as seed nodes but receive only the messages related to their swaps

komodo-defi-framework/mm2src/mm2_main/src/lp_swap.rs

Lines 330 to 353 in e61c41e

	#[cfg(not(target_arch = "wasm32"))]
	return match json::from_slice::<SwapStatus>(msg) {
	Ok(mut status) => {
	status.data.fetch_and_set_usd_prices().await;
	if let Err(e) = save_stats_swap(&ctx, &status.data).await {
	error!("Error saving the swap {} status: {}", status.data.uuid(), e);
	}
	Ok(())
	},
	Err(swap_status_err) => {
	let error = format!(
	"Couldn't deserialize swap msg to either 'SwapMsg': {} or to 'SwapStatus': {}",
	swap_msg_err, swap_status_err
	);
	MmError::err(P2PRequestError::DecodeError(error))
	},
	};
	#[cfg(target_arch = "wasm32")]
	return MmError::err(P2PRequestError::DecodeError(format!(
	"Couldn't deserialize 'SwapMsg': {}",
	swap_msg_err
	)));
	},

For simplicity we should keep it the same way. Hope this is clear :)

[smk762]

closing as complete