TakerFeeValidateFailed with Unexpected opcode OP_PUSHBYTES_70 on BCH

[cipig]

Maker failed this swap https://dexapi.cipig.net/public/error.php?uuid=88bba8e2-dd8d-40e9-9fb3-49752c5d7e5e with

         "event" : {
            "type" : "TakerFeeValidateFailed",
            "data" : {
               "error" : "maker_swap:481] utxo_common:966] utxo_common:934] utxo_common:888] Unexpected opcode OP_PUSHBYTES_70"
            }
         },
         "timestamp" : 1615485729999

Takercoin is BCH, maker is using electrum and is on commit 54eb039, taker is using older version 2.1.2793, but sent TakerFee just fine:

         "timestamp" : 1615485699558,
         "event" : {
            "data" : {
               "tx_hash" : "ccee05a6b5bbc6f50d2a65a5a3a04690d3e2d81082ad57d3ab471189f53dd70d",
               "tx_hex" : "0100000002cae89775f264e50f14238be86a7184b7f77bfe26f54067b794c546ec5eb9c91a020000006b483045022100d6ed080f722a0637a37552382f462230cc438984bc564bdb4b7094f06cfa38fa022062304a52602df1fbb3bebac4f56e1632ad456f62d9031f4983f07e546c8ec4d8412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521ffffffff11f386a6fe8f0431cb84f549b59be00f05e78f4a8a926c5e023a0d5f9112e8200000000069463043021f17eb93ed20a6f2cd357eabb41a4ec6329000ddc6d5b42ecbe642c5d41b206a022026bc4920c4ce3af751283574baa8e4a3efd4dad0d8fe6ba3ddf5d75628d36fda412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521ffffffff0210270000000000001976a914ca1e04745e8ca0c60d8c5881531d51bec470743f88ac57481c00000000001976a914bac11ce4cd2b1df2769c470d09b54f86df737e3c88ac035b4a60"
            },
            "type" : "TakerFeeSent"
         }

https://blockchair.com/bitcoin-cash/transaction/ccee05a6b5bbc6f50d2a65a5a3a04690d3e2d81082ad57d3ab471189f53dd70d
This is the decoded tx:

{
  "txid": "ccee05a6b5bbc6f50d2a65a5a3a04690d3e2d81082ad57d3ab471189f53dd70d",
  "size": 372,
  "version": 1,
  "locktime": 1615485699,
  "vin": [
    {
      "txid": "1ac9b95eec46c594b76740f526fe7bf7b784716ae88b23140fe564f27597e8ca",
      "vout": 2,
      "scriptSig": {
        "asm": "3045022100d6ed080f722a0637a37552382f462230cc438984bc564bdb4b7094f06cfa38fa022062304a52602df1fbb3bebac4f56e1632ad456f62d9031f4983f07e546c8ec4d8[ALL|FORKID] 02ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521",
        "hex": "483045022100d6ed080f722a0637a37552382f462230cc438984bc564bdb4b7094f06cfa38fa022062304a52602df1fbb3bebac4f56e1632ad456f62d9031f4983f07e546c8ec4d8412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521"
      },
      "sequence": 4294967295
    },
    {
      "txid": "20e812915f0d3a025e6c928a4a8fe7050fe09bb549f584cb31048ffea686f311",
      "vout": 0,
      "scriptSig": {
        "asm": "3043021f17eb93ed20a6f2cd357eabb41a4ec6329000ddc6d5b42ecbe642c5d41b206a022026bc4920c4ce3af751283574baa8e4a3efd4dad0d8fe6ba3ddf5d75628d36fda[ALL|FORKID] 02ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521",
        "hex": "463043021f17eb93ed20a6f2cd357eabb41a4ec6329000ddc6d5b42ecbe642c5d41b206a022026bc4920c4ce3af751283574baa8e4a3efd4dad0d8fe6ba3ddf5d75628d36fda412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521"
      },
      "sequence": 4294967295
    }
  ],
  "vout": [
    {
      "value": 0.00010000,
      "n": 0,
      "scriptPubKey": {
        "asm": "OP_DUP OP_HASH160 ca1e04745e8ca0c60d8c5881531d51bec470743f OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "76a914ca1e04745e8ca0c60d8c5881531d51bec470743f88ac",
        "reqSigs": 1,
        "type": "pubkeyhash",
        "addresses": [
          "bitcoincash:qr9pupr5t6x2p3sd33vgz5ca2xlvgur58ucaeq0lkx"
        ]
      }
    },
    {
      "value": 0.01853527,
      "n": 1,
      "scriptPubKey": {
        "asm": "OP_DUP OP_HASH160 bac11ce4cd2b1df2769c470d09b54f86df737e3c OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "76a914bac11ce4cd2b1df2769c470d09b54f86df737e3c88ac",
        "reqSigs": 1,
        "type": "pubkeyhash",
        "addresses": [
          "bitcoincash:qzavz88ye543munkn3rs6zd4f7rd7um78ss9uuluya"
        ]
      }
    }
  ],
  "confirmations": 0,
  "hex": "0100000002cae89775f264e50f14238be86a7184b7f77bfe26f54067b794c546ec5eb9c91a020000006b483045022100d6ed080f722a0637a37552382f462230cc438984bc564bdb4b7094f06cfa38fa022062304a52602df1fbb3bebac4f56e1632ad456f62d9031f4983f07e546c8ec4d8412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521ffffffff11f386a6fe8f0431cb84f549b59be00f05e78f4a8a926c5e023a0d5f9112e8200000000069463043021f17eb93ed20a6f2cd357eabb41a4ec6329000ddc6d5b42ecbe642c5d41b206a022026bc4920c4ce3af751283574baa8e4a3efd4dad0d8fe6ba3ddf5d75628d36fda412102ae7dc4ef1b49aadeff79cfad56664105f4d114e1716bc4f930cb27dbd309e521ffffffff0210270000000000001976a914ca1e04745e8ca0c60d8c5881531d51bec470743f88ac57481c00000000001976a914bac11ce4cd2b1df2769c470d09b54f86df737e3c88ac035b4a60"
}

[artemii235]

Thanks for opening the issue, I'm checking it right now.

[artemii235]

Please update your makers with the latest commit, the problem is related to recent changes of dex fee validation code. It didn't take the possibility of 70 bytes length DER signature, and now it does.

[cipig]

Done, thanks for the fix. I don't know how to reproduce/test it though, because it wasn't failing all the time, many BCH swaps went fine before too. Did some new swaps with BCH as takercoin and new makers and they worked fine, so i think you can close the issue.

[artemii235]

Ok, please feel free to reopen the issue if the problem reoccurs. Thanks again for the report!