Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit sign_raw_transaction RPC method documentation #276

Open
harsenyan3 opened this issue Jul 16, 2024 · 2 comments
Open

Edit sign_raw_transaction RPC method documentation #276

harsenyan3 opened this issue Jul 16, 2024 · 2 comments
Assignees
@AndrewDelaney @smk762
Labels
awaiting review P1 Important task which needs to be completed soon v2.1.0-beta-changelog

Comments

@harsenyan3
Copy link
Collaborator

harsenyan3 commented Jul 16, 2024 •
edited
Loading

Review docs for "sign_raw_transaction" RPC method.

  1. Inconsistencies in query parametes between UTXO and EVM (feat(tx): add new sign_raw_transaction rpc for UTXO and EVM coins komodo-defi-framework#1930 (comment))
  2. Test method and add additional dev comments

Refer to PR#1930 (KomodoPlatform/komodo-defi-framework#1930) for more info.
@harsenyan3 harsenyan3 changed the title Add sign_raw_transaction RPC method documentation Edit sign_raw_transaction RPC method documentation Jul 16, 2024
@smk762 smk762 assigned smk762 and AndrewDelaney and unassigned AndrewDelaney Jul 25, 2024
@smk762
Copy link
Contributor

smk762 commented Jul 25, 2024

Initial docs for this were added in #161
@AndrewDelaney please test the examples in https://komodoplatform.com/en/docs/komodo-defi-framework/api/v20/sign_raw_transaction/ to confirm requests function as expected, response has not changed, and doc is clear / not confusing.
I'll cover re-testing the hardware wallet (Trezor) related parts.

@smk762
Copy link
Contributor

smk762 commented Sep 13, 2024

@AndrewDelaney please test this at your earliest convenience and report results below.

@smk762 smk762 added the P1 Important task which needs to be completed soon label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewDelaney AndrewDelaney

@smk762 smk762

Labels
awaiting review P1 Important task which needs to be completed soon v2.1.0-beta-changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndrewDelaney @smk762 @harsenyan3