Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Order book showing incorrect values #89

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Fix - Order book showing incorrect values #89

merged 8 commits into from
Dec 18, 2023

Conversation

CharlVS
Copy link
Member

@CharlVS CharlVS commented Dec 17, 2023

Fixes #85

To test:

Activate KMD and LBC and then compare with https://markets.atomicdex.io/orderbook/KMD-LBC on the order book page.

@CharlVS CharlVS added the bug Something isn't working label Dec 17, 2023
@CharlVS CharlVS requested review from cipig and smk762 December 17, 2023 19:52
@CharlVS CharlVS self-assigned this Dec 17, 2023
@CharlVS CharlVS added the QA Ready for QA testing label Dec 17, 2023
@CharlVS CharlVS changed the base branch from master to dev December 17, 2023 19:57
@CharlVS CharlVS added the 0.9.0 v0.9.0 release: Net ID migration and order book + file export bug fixes. label Dec 17, 2023
@CharlVS CharlVS changed the title Order book fixes Fix - Order book showing incorrect values Dec 17, 2023
Copy link
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@smk762 smk762 requested a review from kivqa December 17, 2023 20:41
@ca333 ca333 merged commit 93c4041 into dev Dec 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.0 v0.9.0 release: Net ID migration and order book + file export bug fixes. bug Something isn't working QA Ready for QA testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume of bids in orderbooks are wrong
4 participants