-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup automated CI testing for PRs using GitHub actions #114
Comments
I had this lying around for some time already, but not yet finished. Will take a look again. |
Wow swiftshader looks awesome - interestingly enough I have been wanting to find something for quite a LONG time now, I have an open issue in the VK HPP repo which has had no movement KhronosGroup/Vulkan-Hpp#734 Haha good point on the glsl piece! Having said that tho, I would still be keen to explore the point about just installing shaderc, as potentailly that could make sure that it's always possible to pass string shaders (without the need to first convert them into spirv explicitly with the glsl dependency). The point on swiftshader is very interesting tho - have you had a chance to try it by any chance? |
Yes it works fine. I'm already using it for CI in a private repo. |
Interesting. Do you have a snippet that you coudl share? Or is this something you think you could add to the cmake file for the tests? This would really bring a lot of value as then it would be possible to set up github actions to run the tests on every PR submitted |
Here are also Swiftshader Windows binaries. However I remember I got a segfault when using Kompute Python with it. The Vulkan sample apps like vkcube.exe work fine however. |
Currently all PRs that have been contributed require pulling the specific branch and running the tests. It would provide much more speedy development cycles especially for contributors through automated CI builds that show on each of the PRs.
This PR encompasses exploring setting up automated CI tests initially for C++, but also for the python tests.
The text was updated successfully, but these errors were encountered: