Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eStorage Tensors are currently unusable as OpTensorCreate calls mapDataIntoHostMemory #132

Closed
axsaucedo opened this issue Feb 6, 2021 · 1 comment

Comments

@axsaucedo
Copy link
Member

As reported by @alexander-g in #14:

It seems they are currently unusable. I cannot use OpTensorCreate with them because this op tries to call mapDataIntoHostMemory() on them which is only valid for staging tensors. I also cannot manually call init() because I cannot access the Manager's vk::PhysicalDevice and vk::Device which are private.

Following up the response was:

Storage tensors may still be useful if the users want to make available memory to use within the GPU that would only be used to store data as any processing is being computed but it's not expected to be used to be sent back to the host. I will open an issue to make sure this is addressed.

This issue encompassess the exploration to first fix the way to make the tensors functional. This could go as part of #48 which coudl involve having a OpTensorInitialise function that only initialises / reinitialises a tensor, which currently is not possible in a simple way.

@axsaucedo
Copy link
Member Author

This was resolved via #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant