Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide further granularity on handling staging tensors #40

Closed
axsaucedo opened this issue Sep 5, 2020 · 0 comments
Closed

Provide further granularity on handling staging tensors #40

axsaucedo opened this issue Sep 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@axsaucedo
Copy link
Member

Currently staging tensors are created by OpCreateTensor but they are kept for the life of the OpCreateTensor. Should explore ways to expose more granular functionality, whereby the mStaging tensors may only be needed once, for example, in the case of input tensors. There are other cases where the staging tensors would be expected to be used many times, in case that ther input tensor is to be updated multiple times from the host (to avoid creating a staging tensor every time). This may require potentially moving the staging tensor ownership into the Tensor class itslef. This would mean that the ownership for the vulkan memory of this tensor would still be owned by the life of the OpCreateTensor, but it would still be possible to have other functions like an OpMapData (as per #39) which could still leverage the staging tensor (whcih can either be already existing or created/destroyed in the single operation.

@axsaucedo axsaucedo added the enhancement New feature or request label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant