Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preSubmit function to OpBase to account for multiple eval commands in parallel #47

Closed
axsaucedo opened this issue Sep 6, 2020 · 1 comment
Closed

Add preSubmit function to OpBase to account for multiple eval commands in parallel #47

axsaucedo opened this issue Sep 6, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@axsaucedo
Copy link
Member

Currently there is functionality for postSubmit which is executed after the submission has been carried out. However there are situations where there are commands that need to be carried out on every eval, such as in the case of the OpTensorSyncDevice, where the data should be copied and mapped into the device memory before the record command is re-executed.
@axsaucedo axsaucedo added the enhancement New feature or request label Sep 6, 2020
@axsaucedo
Copy link
Member Author

axsaucedo commented Sep 6, 2020 •
edited
Loading

postSubmit (and presubmit) will be renamed to preEval and postEval to align with the Kompute reminology

@axsaucedo axsaucedo mentioned this issue Sep 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axsaucedo