Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konnect integration test Test_Dump_SkipConsumers_Konnect failing #1461

Closed
pmalek opened this issue Dec 4, 2024 · 1 comment · Fixed by #1462
Closed

Konnect integration test Test_Dump_SkipConsumers_Konnect failing #1461

pmalek opened this issue Dec 4, 2024 · 1 comment · Fixed by #1462

Comments

@pmalek
Copy link
Member

pmalek commented Dec 4, 2024

Problem statement

After unblocking the CI with missing secret (for --app dependabot) it seems that the tests are failing, failed pipelines:

  • https://github.com/Kong/deck/actions/runs/12162521988/job/33919860795

        dump_test.go:219: 
        	    Error Trace:	/home/runner/work/deck/deck/tests/integration/dump_test.go:219
        	    Error:      	Not equal: 
        	            	    expected: "_format_version: \"3.0\"\n_konnect:\n  control_plane_name: default\nconsumer_groups:\n- name: basic\n  plugins:\n  - config:\n      consumer_groups: null\n      dictionary_name: kong_rate_limiting_counters\n      disable_penalty: false\n      enforce_consumer_groups: false\n      error_code: 429\n      error_message: API rate limit exceeded\n      header_name: null\n      hide_client_headers: false\n      identifier: consumer\n      limit:\n      - 30000\n      lock_dictionary_name: kong_locks\n      namespace: basic\n      path: null\n      redis:\n        cluster_addresses: null\n        cluster_max_redirections: 5\n        cluster_nodes: null\n        connect_timeout: 2000\n        connection_is_proxied: false\n        database: 0\n        host: 127.0.0.1\n        keepalive_backlog: null\n        keepalive_pool_size: 256\n        password: null\n        port: 6379\n        read_timeout: 2000\n        send_timeout: 2000\n        sentinel_addresses: null\n        sentinel_mas
        	            	    actual  : "_format_version: \"3.0\"\n_konnect:\n  control_plane_name: default\nconsumer_groups:\n- name: basic\n  plugins:\n  - config:\n      compound_identifier: null\n      consumer_groups: null\n      dictionary_name: kong_rate_limiting_counters\n      disable_penalty: false\n      enforce_consumer_groups: false\n      error_code: 429\n      error_message: API rate limit exceeded\n      header_name: null\n      hide_client_headers: false\n      identifier: consumer\n      limit:\n      - 30000\n      lock_dictionary_name: kong_locks\n      namespace: basic\n      path: null\n      redis:\n        cluster_addresses: null\n        cluster_max_redirections: 5\n        cluster_nodes: null\n        connect_timeout: 2000\n        connection_is_proxied: false\n        database: 0\n        host: 127.0.0.1\n        keepalive_backlog: null\n        keepalive_pool_size: 256\n        password: null\n        port: 6379\n        read_timeout: 2000\n        redis_proxy_type: null\n        send_time
        	            	    
        	            	    Diff:
        	            	    --- Expected
        	            	    +++ Actual
        	            	    @@ -7,2 +7,3 @@
        	            	       - config:
        	            	    +      compound_identifier: null
        	            	           consumer_groups: null
        	            	    @@ -34,2 +35,3 @@
        	            	             read_timeout: 2000
        	            	    +        redis_proxy_type: null
        	            	             send_timeout: 2000
        	    Test:       	Test_Dump_SkipConsumers_Konnect/dump_with_no_skip-consumers
    
  • https://github.com/Kong/deck/actions/runs/12123234820/job/33920986213

        dump_test.go:219: 
        	    Error Trace:	/home/runner/work/deck/deck/tests/integration/dump_test.go:219
        	    Error:      	Not equal: 
        	            	    expected: "_format_version: \"3.0\"\n_konnect:\n  control_plane_name: default\nconsumer_groups:\n- name: basic\n  plugins:\n  - config:\n      compound_identifier: null\n      consumer_groups: null\n      dictionary_name: kong_rate_limiting_counters\n      disable_penalty: false\n      enforce_consumer_groups: false\n      error_code: 429\n      error_message: API rate limit exceeded\n      header_name: null\n      hide_client_headers: false\n      identifier: consumer\n      limit:\n      - 30000\n      lock_dictionary_name: kong_locks\n      namespace: basic\n      path: null\n      redis:\n        cluster_addresses: null\n        cluster_max_redirections: 5\n        cluster_nodes: null\n        connect_timeout: 2000\n        connection_is_proxied: false\n        database: 0\n        host: 127.0.0.1\n        keepalive_backlog: null\n        keepalive_pool_size: 256\n        password: null\n        port: 6379\n        read_timeout: 2000\n        send_timeout: 2000\n        sentinel_addr
        	            	    actual  : "_format_version: \"3.0\"\n_konnect:\n  control_plane_name: default\nconsumer_groups:\n- name: basic\n  plugins:\n  - config:\n      compound_identifier: null\n      consumer_groups: null\n      dictionary_name: kong_rate_limiting_counters\n      disable_penalty: false\n      enforce_consumer_groups: false\n      error_code: 429\n      error_message: API rate limit exceeded\n      header_name: null\n      hide_client_headers: false\n      identifier: consumer\n      limit:\n      - 30000\n      lock_dictionary_name: kong_locks\n      namespace: basic\n      path: null\n      redis:\n        cluster_addresses: null\n        cluster_max_redirections: 5\n        cluster_nodes: null\n        connect_timeout: 2000\n        connection_is_proxied: false\n        database: 0\n        host: 127.0.0.1\n        keepalive_backlog: null\n        keepalive_pool_size: 256\n        password: null\n        port: 6379\n        read_timeout: 2000\n        redis_proxy_type: null\n        send_time
        	            	    
        	            	    Diff:
        	            	    --- Expected
        	            	    +++ Actual
        	            	    @@ -35,2 +35,3 @@
        	            	             read_timeout: 2000
        	            	    +        redis_proxy_type: null
        	            	             send_timeout: 2000
        	    Test:       	Test_Dump_SkipConsumers_Konnect/dump_with_no_skip-consumers
    
@pmalek
Copy link
Member Author

pmalek commented Dec 4, 2024

This seems to be related to

which were recently merged but I'm wondering why those are already used in Konnect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant