feat(analytics): add status color tokens [MA-2473] #329
Conversation
mihai-peteu
requested review from
adamdehaven,
jillztom,
portikM and
ValeryG
as code owners
|
Awaiting Slack approval from UX, but otherwise ready to review. |
There was a problem hiding this comment.
A couple general comments:
-
In the token descriptions, we shouldn't reference "Analytics" -- these status codes should be generic for "statuses" in general, so can we update the
commentfields to read something like this:- (before):
Analytics unknown 2xx request status color (green.10). - (after):
Color for an unknown 200-299 range response (green.10)
- (before):
-
For the "range tokens" (such as
400s) can we update the comment to indicate it can be used for the whole range? Something likeColor to represent the response code range from 400-499 (orange.40) -
You will want to update the stylelint plugin to allow the use of the status tokens for a few properties. I'd recommend adding
'status-color'to the following properties:backgroundbackground-colorcolorfillstroke
# [1.17.0](v1.16.0...v1.17.0) (2024-08-09) ### Features * **analytics:** add status color tokens [MA-2473] ([#329](#329)) ([b719a9b](b719a9b))
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
https://konghq.atlassian.net/browse/MA-2473
Refer to the rightmost "Proposal 5 Final" tab in the spreadsheet below:
https://docs.google.com/spreadsheets/d/1RZyhXMJCr_bD5VNr3fubZx1isp3DmZGaL75TvYCPG-Q/edit?gid=80633302#gid=80633302