-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): add status color tokens [MA-2473] #329
Conversation
Awaiting Slack approval from UX, but otherwise ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple general comments:
-
In the token descriptions, we shouldn't reference "Analytics" -- these status codes should be generic for "statuses" in general, so can we update the
comment
fields to read something like this:- (before):
Analytics unknown 2xx request status color (green.10).
- (after):
Color for an unknown 200-299 range response (green.10)
- (before):
-
For the "range tokens" (such as
400s
) can we update the comment to indicate it can be used for the whole range? Something likeColor to represent the response code range from 400-499 (orange.40)
-
You will want to update the stylelint plugin to allow the use of the status tokens for a few properties. I'd recommend adding
'status-color'
to the following properties:background
background-color
color
fill
stroke
# [1.17.0](v1.16.0...v1.17.0) (2024-08-09) ### Features * **analytics:** add status color tokens [MA-2473] ([#329](#329)) ([b719a9b](b719a9b))
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
https://konghq.atlassian.net/browse/MA-2473
Refer to the rightmost "Proposal 5 Final" tab in the spreadsheet below:
https://docs.google.com/spreadsheets/d/1RZyhXMJCr_bD5VNr3fubZx1isp3DmZGaL75TvYCPG-Q/edit?gid=80633302#gid=80633302