Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URL for internal links in Custom Resources page of KIC #3893

Closed
2 tasks done
randmonkey opened this issue Apr 29, 2022 · 1 comment
Closed
2 tasks done

Incorrect URL for internal links in Custom Resources page of KIC #3893

randmonkey opened this issue Apr 29, 2022 · 1 comment

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Apr 29, 2022

Where is the problem?

https://docs.konghq.com/kubernetes-ingress-controller/latest/concepts/custom-resources/#kongingress

What happened?

The URL of Upstream link in the first paragraph links to URL https://docs.konghq.com/gateway/latest/admin-api/#upstream-objects (plural), but the correct internal link of Upstream Object in kong admin API is https://docs.konghq.com/gateway/latest/admin-api/#upstream-object (singular). The issue results to that when clicking the Upstream link, the web page goes to the top of kong admin APIs, but not the paragraph introducing Upstream object.

also, most versions of https://docs.konghq.com/gateway/latest/reference/health-checks-circuit-breakers/, including the latest verision, have this wrong internal link. (only versions prior or equal to 0.14.x of admin api uses #upstream-objects ).

What did you expect to happen?

Web page goes to the paragraph introducing Upstream object of kong Admin API. when Upstream link is clicked

Code of Conduct and Community Expectations

  • I agree to follow this project's Code of Conduct
  • I agree to abide by the Community Expectations
@mheap
Copy link
Member

mheap commented Apr 29, 2022

Closed via #3895

@mheap mheap closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants