Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider plugin bindings combinations created by annotating KongService, KongRoute, KongConsumer and KongConsumerGroup objects #660

Open
4 tasks
Tracked by #827
pmalek opened this issue Sep 26, 2024 · 1 comment

Comments

@pmalek
Copy link
Member

pmalek commented Sep 26, 2024

Problem statement

#644 introduced creation of KongPluginBindings based on konghq.com/plugins annotations on entities that can have plugins bound (for this specific PR Services and Routes have received support).

In order to do so, the operator needs to generate combinations of objects that should be set as targets of a plugin.

This in the operator is achieved using KongPluginBindings.

So for instance, if a plugin annotation is set on a KongRoute r1 and KongService s1 should the operator

  1. Create 2 bindings: 1 binding for KongRoute and 1 for KongService
  2. Create 2 bindings: 1 binding for KongRoute and KongService, and 1 for KongService
  3. Create 1 binding: for KongRoute and KongService

?

KIC uses the 1st approach backed by a UT in here. This might be considered incorrect on its own but this issue does not focus on that.

This issue tracks the decision that has to be made (which might influence how KIC acts as well) whether to change the behavior described above.

#659 changes the behavior that has been introduced by #644 from 3 to 1 ( to align with KIC ).

Acceptance criteria

  • A decision is made on the above mentioned behavior.
    • Implementation of change of said behavior is implemented (if change was the decision).
  • A decision is made whether KIC's behavior should also change (if the decision above is to change).
    • KIC issue is created (if change was the decision).
@pmalek
Copy link
Member Author

pmalek commented Oct 9, 2024

Moving this out of 1.4 as we won't change the behavior at this moment (just before releasing 1.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant